-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to run experiments on first run on Windows #34150
Comments
@brave/qa-team I'll grab this one and run through a few checks/build off the STR/Cases that @mherrmann mentions via #34150 (comment). |
@mherrmann unfortunately I don't think the above is working. When launching STR/Cases:
Installers Checked:
Also quickly checked and ensured that there wasn't any issues re: downloading the seed file on first launch. However, that seems like it's working without issues. Its just not being applied on first launch.
|
Thank you for catching this @kjozwiak. I can reproduce the issue and will investigate. One thing I should have made clearer is that the variations seed only gets fetched by the online installer. So I do not expect it to be applied on first run when installing with the offline installer. I will update the issue description. |
Created #35232 as a follow up. We'll keep the above as |
@kjozwiak This issue is verified via #35232 (comment) so labelling this issue as |
Description
At the moment, Brave on Windows downloads the variations seed on first run - but it only takes effect after a browser restart. This means that we cannot run experiments for first-run behavior.
The goal of this issue is to make it possible to run experiments during first-run use on Windows via Griffin. It requires changes on the devops side as well as in the browser. This issue supersedes the associated devops issue for visibility in release notes and for QA. It is the Windows part of #15229.
Note: For technical reasons, this change will only affect the 1 MB online installer, not the offline installer.
cc @goodov @iefremov @chrismore
Test Plan:
Please make sure that Brave's online and offline installers for Windows still work. For the online installer, please find a way to check whether an expected experiment was run on first run - that is, in the browser session that launches automatically from the online installer.
The text was updated successfully, but these errors were encountered: