Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variations on Windows first run #20829

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

mherrmann
Copy link
Collaborator

@mherrmann mherrmann commented Nov 3, 2023

For brave/brave-browser#34150, to be completed by a devops PR that turns on the new implementation.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

@mherrmann mherrmann added the CI/skip Do not run CI builds (except noplatform) label Nov 3, 2023
@mherrmann mherrmann self-assigned this Nov 3, 2023
@mherrmann mherrmann removed the CI/skip Do not run CI builds (except noplatform) label Nov 7, 2023
@mherrmann mherrmann changed the title Win: Support variations on first run Support variations on Windows first run Nov 7, 2023
@mherrmann mherrmann force-pushed the support-variations-on-first-run-windows branch from cd08c8d to a98e42a Compare November 7, 2023 21:36
@mherrmann mherrmann force-pushed the support-variations-on-first-run-windows branch from a98e42a to d5eb84c Compare November 7, 2023 21:38
@mherrmann mherrmann marked this pull request as ready for review November 7, 2023 21:38
@mherrmann mherrmann requested review from a team and bridiver as code owners November 7, 2023 21:38
@mherrmann mherrmann enabled auto-merge (squash) November 9, 2023 10:27
@mherrmann mherrmann merged commit 514bdd7 into master Nov 9, 2023
19 checks passed
@mherrmann mherrmann deleted the support-variations-on-first-run-windows branch November 9, 2023 10:52
@github-actions github-actions bot added this to the 1.62.x - Nightly milestone Nov 9, 2023
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants