Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publisher list should go into retries #3639

Closed
LaurenWags opened this issue Mar 8, 2019 · 1 comment · Fixed by brave/brave-core#1906
Closed

publisher list should go into retries #3639

LaurenWags opened this issue Mar 8, 2019 · 1 comment · Fixed by brave/brave-core#1906

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Mar 8, 2019

Description

Per discussion with @NejcZdovc , if publisher list cannot be loaded for any reason, it should go into retries.

Steps to Reproduce

  1. Clean profile, enable Rewards.
  2. Visit a verified site (brave.com) for min time.
  3. Open a new tab. Close brave.com.
  4. Navigate to rewards page, make sure site is recorded in ac table.
  5. Close brave.
  6. Delete publisher_list from profile folder.
  7. Launch Brave
  8. Navigate to another verified site (like DDG) for min time.
  9. Open panel, site does not show as verified.
  10. Open a new tab.
  11. Navigate to Rewards page.
  12. Site is listed in a-c table but is not verified.
  13. Open a new tab, navigate to brave.com for min time.
  14. Navigate to Brave Rewards page.
  15. brave.com no longer shows as verified.

Actual result:

publisher list could not be reached (in this case it did not exist), so all sites showed as unverified.

Expected result:

since publisher list could not be reached, it should have gone into retries and refetched from server.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.60.48 Chromium: 72.0.3626.121 (Official Build) (64-bit)
Revision da3787ba355f18db7db52abf75c42afb408d656f-refs/branch-heads/3626@{#883}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

@NejcZdovc NejcZdovc self-assigned this Mar 9, 2019
@NejcZdovc NejcZdovc added this to the 0.64.x - Nightly milestone Mar 9, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Mar 10, 2019
@jsecretan jsecretan added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Mar 19, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Mar 26, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 1, 2019

Verification passed on

Brave 0.62.49 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Windows 10 OS Build 17134.523

Verification passed on

Brave 0.62.49 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Linux

Verified passed with

Brave 0.62.49 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants