Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes publisher list re-try logic #1906

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Fixes publisher list re-try logic #1906

merged 1 commit into from
Mar 26, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 10, 2019

Resolves brave/brave-browser#3639

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • clean profile
  • enable rewards
  • go to profile folder and make sure that you see publisher_list file
  • close browser
  • delete publisher_list file
  • start browser again
  • make sure that file is downloaded again without any delay (like minutes)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

if (lastLoadTimestamp == 0ull || immediately) {
start_timer_in = 0ull;
} else if (retryAfterError) {
start_timer_in = retryRequestSetup(60, 300);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retry timer was reduced to 1-5min as it's really important to get this list asap. Endpoint is behind CDN so we should be good here

Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browser_tests are failing.

Getting spammed with error:

[13008:775:0325/103315.310392:INFO:confirmations_impl.cc(638)] OnTimer:
  timer_id: 5
  retry_getting_signed_tokens_timer_id_: 0
  payout_redeemed_tokens_timer_id_: 0
[13008:775:0325/103315.318928:ERROR:ledger_impl.cc(805)] Can't fetch publisher list
[13008:775:0325/103315.321677:INFO:confirmations_impl.cc(413)] Successfully saved confirmations state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publisher list should go into retries
2 participants