-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes publisher list re-try logic #1906
Conversation
90c9523
to
72a3e99
Compare
if (lastLoadTimestamp == 0ull || immediately) { | ||
start_timer_in = 0ull; | ||
} else if (retryAfterError) { | ||
start_timer_in = retryRequestSetup(60, 300); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retry timer was reduced to 1-5min as it's really important to get this list asap. Endpoint is behind CDN so we should be good here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
browser_tests are failing.
Getting spammed with error:
[13008:775:0325/103315.310392:INFO:confirmations_impl.cc(638)] OnTimer:
timer_id: 5
retry_getting_signed_tokens_timer_id_: 0
payout_redeemed_tokens_timer_id_: 0
[13008:775:0325/103315.318928:ERROR:ledger_impl.cc(805)] Can't fetch publisher list
[13008:775:0325/103315.321677:INFO:confirmations_impl.cc(413)] Successfully saved confirmations state
Resolves brave/brave-browser#3639
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
publisher_list
filepublisher_list
fileReviewer Checklist: