Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokens that fail to redeem due to network errors should be added to a queue and retried #3662

Closed
jsecretan opened this issue Mar 11, 2019 · 4 comments · Fixed by brave/brave-core#2035, brave/brave-core#2072 or brave/brave-core#2108

Comments

@jsecretan
Copy link

jsecretan commented Mar 11, 2019

Test plan

See brave/brave-core#2035

Description

Tokens that fail to redeem due to network errors should be added to a queue and retried. The creative_instance_id (uuid) should be added back to the queue until successful.

@bsclifton
Copy link
Member

@tmancey just added missing labels / test plan; please update if it should be different 😄

@yrliou
Copy link
Member

yrliou commented Mar 25, 2019

Reopen the issue because this is being revert for fixing #3883

@yrliou yrliou reopened this Mar 25, 2019
@jumde
Copy link
Contributor

jumde commented Mar 28, 2019

Re-opened with C74 revert

@jumde jumde reopened this Mar 28, 2019
@jumde jumde removed this from the 0.64.x - Nightly milestone Mar 28, 2019
tmancey added a commit to brave/brave-core that referenced this issue Mar 28, 2019
tmancey added a commit to brave/brave-core that referenced this issue Mar 28, 2019
@tmancey tmancey added this to the 0.64.x - Dev milestone Apr 1, 2019
tmancey added a commit to brave/brave-core that referenced this issue Apr 1, 2019
tmancey added a commit to brave/brave-core that referenced this issue Apr 3, 2019
@tmancey tmancey modified the milestones: 0.64.x - Dev, 0.63.x - Beta Apr 3, 2019
@srirambv
Copy link
Contributor

srirambv commented Apr 18, 2019

Verification passed on

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta (64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Linux
  • Failed transaction in confirmations.json
    image
  • Failed transaction redeemed in confirmations.json
    image

Verification passed on

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta (64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Windows 10 OS Build 17134.523

Failed transaction
image

Retried transaction
image

Verification PASSED on macOS 10.14.4 x64 using the following build:

Brave 0.63.47 Chromium: 74.0.3729.108 (Official Build) (64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Mac OS X

Failed Confirmation:

Screen Shot 2019-04-23 at 9 04 43 PM

[48010:775:0423/210350.063316:ERROR:redeem_token.cc(168)] Failed to create confirmation
[48010:775:0423/210350.063330:INFO:confirmations_impl.cc(782)] Removed 165dbb86-eca0-4c10-92f4-f725d2126d6b creative instance id for dismiss from the confirmation queue
[48010:775:0423/210350.063347:INFO:confirmations_impl.cc(642)] Saving confirmations state
[48010:775:0423/210350.063820:WARNING:redeem_token.cc(405)] Failed to redeem token with 165dbb86-eca0-4c10-92f4-f725d2126d6b creative instance id for dismiss
[48010:775:0423/210350.063845:INFO:redeem_token.cc(411)] Retry 165dbb86-eca0-4c10-92f4-f725d2126d6b creative instance id for dismiss
[48010:775:0423/210350.063861:INFO:redeem_token.cc(415)] Added 165dbb86-eca0-4c10-92f4-f725d2126d6b creative instance id for dismiss to the confirmations queue
[48010:775:0423/210350.063878:INFO:confirmations_impl.cc(642)] Saving confirmations state

Successful Confirmation:

[48010:775:0423/210905.541504:INFO:confirmations_impl.cc(642)] Saving confirmations state
[48010:775:0423/210905.542074:INFO:confirmations_impl.cc(782)] Removed 165dbb86-eca0-4c10-92f4-f725d2126d6b creative instance id for dismiss from the confirmation queue
[48010:775:0423/210905.542111:INFO:confirmations_impl.cc(642)] Saving confirmations state
[48010:775:0423/210905.542677:INFO:redeem_token.cc(423)] Successfully redeemed token with 165dbb86-eca0-4c10-92f4-f725d2126d6b creative instance id for dismiss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment