Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokens that fail to redeem due to network errors should be added to a queue and retried #2035

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Tokens that fail to redeem due to network errors should be added to a queue and retried #2035

merged 1 commit into from
Mar 25, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 22, 2019 •
edited
Loading

fixes brave/brave-browser#3662

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Confirm failed requests are added to the Defaults/rewards_service/confirmations.json under confirmations/failed_confirmations and confirmation redemption is retried every 5 minutes +/- jitter until successful. Items that are retried and fail should move to the back of the queue.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@tmancey tmancey added this to the 0.64.x - Nightly milestone Mar 22, 2019
@tmancey tmancey self-assigned this Mar 22, 2019
@tmancey tmancey requested review from emerick, evq and NejcZdovc March 22, 2019 16:42
emerick
emerick previously approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of really minor comments

vendor/bat-native-ads/src/bat/ads/confirmation_type.cc Outdated Show resolved Hide resolved
vendor/bat-native-confirmations/src/bat/confirmations/confirmation_type.cc Outdated Show resolved Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/ledger_impl.cc Outdated Show resolved Hide resolved
@tmancey tmancey force-pushed the issues/3662 branch 4 times, most recently from fc89a11 to eb9129d Compare March 25, 2019 10:59
@emerick emerick self-requested a review March 25, 2019 12:06
emerick
emerick previously approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey force-pushed the issues/3662 branch 2 times, most recently from b8e8762 to d2aad12 Compare March 25, 2019 13:13
@tmancey tmancey requested a review from emerick March 25, 2019 13:19
emerick
emerick previously approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey requested a review from emerick March 25, 2019 16:37
emerick
emerick approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey merged commit 47fe612 into master Mar 25, 2019
@tmancey tmancey deleted the issues/3662 branch March 25, 2019 16:43
@tmancey tmancey mentioned this pull request Mar 25, 2019
Merged
@jsecretan jsecretan mentioned this pull request Mar 25, 2019
Closed
yrliou added a commit that referenced this pull request Mar 25, 2019
@yrliou
Merge pull request #2058 from brave/revert_pr_1943_and_2035
9f10c0c 
Revert PR #1943 and #2035
yrliou added a commit that referenced this pull request Mar 25, 2019
@yrliou
Merge pull request #2067 from brave/uplift_2058
a5452f4 
Uplift Revert PR #1943 and #2035 for 0.63.x
@tmancey tmancey restored the issues/3662 branch March 25, 2019 22:18
@tmancey tmancey mentioned this pull request Apr 2, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

@evq evq Awaiting requested review from evq

@NejcZdovc NejcZdovc Awaiting requested review from NejcZdovc

Assignees

@tmancey tmancey

Labels
feature/ads feature/rewards security
Projects
None yet
Milestone
0.64.x - Release
Development

Successfully merging this pull request may close these issues.

Tokens that fail to redeem due to network errors should be added to a queue and retried
4 participants
@tmancey @emerick @bsclifton @ryanml