Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI Navigation Bar sub-menu has light-on-light items in dark mode for c74 #3965

Closed
petemill opened this issue Apr 1, 2019 · 2 comments
Closed

Comments

@petemill
Copy link
Member

petemill commented Apr 1, 2019

WebUI Navigation Bar sub-menu should be on dark background in dark mode
C74 only

Test plan / STR:

  1. Visit Bookmarks Page

Actual:
image

Expected:
Dark background

@bsclifton
Copy link
Member

Resolved when C74 was merged to master with #3931 😄

@kjozwiak
Copy link
Member

kjozwiak commented May 29, 2019

Verification PASSED on macOS 10.14.5 x64 using the following build:

Brave 0.65.113 Chromium: 75.0.3770.38 (Official Build) beta(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Mac OS X
  • Example of chrome://bookmarks/:

Screen Shot 2019-05-29 at 11 43 36 AM

Screen Shot 2019-05-29 at 11 53 00 AM

Screen Shot 2019-05-29 at 11 43 52 AM

Screen Shot 2019-05-29 at 11 52 48 AM

  • Example of chrome://downloads/:

Screen Shot 2019-05-29 at 12 06 14 PM

Screen Shot 2019-05-29 at 12 06 21 PM

Screen Shot 2019-05-29 at 12 06 45 PM

Screen Shot 2019-05-29 at 12 06 50 PM

Verification passed on

Brave 0.65.113 Chromium: 75.0.3770.38 (Official Build) beta(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux

Downloads page
image
image

Bookmarks page
image
image

Dark/Light theme has no change on Linux.

Verification passed on

Brave 0.65.114 Chromium: 75.0.3770.38 (Official Build) (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Windows 10 OS Version 1803 (Build 17134.765)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment