Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 73.0.3683.75 to Chromium 74.0.3729.40 #2117

Merged
merged 9 commits into from
Apr 2, 2019
Merged

Upgrade from Chromium 73.0.3683.75 to Chromium 74.0.3729.40 #2117

merged 9 commits into from
Apr 2, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Mar 28, 2019 •
edited by bsclifton
Loading

Fixes brave/brave-browser#3502, brave/brave-browser#3894, brave/brave-browser#3965
Related: brave/brave-browser#3931

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@mkarolin mkarolin self-assigned this Mar 28, 2019
@mkarolin mkarolin mentioned this pull request Mar 28, 2019
Merged
16 tasks
@bsclifton
Copy link
Member

Blocked on #2114

@bsclifton bsclifton added this to the 0.65.x - Nightly milestone Apr 1, 2019
@bsclifton
Copy link
Member

I pulled down locally and it builds great + unit tests pass. Getting some rewards related browser tests failing though. Do you experience those too, @mkarolin ?

@mkarolin
Copy link
Collaborator Author

mkarolin commented Apr 1, 2019

@bsclifton, no all unit and browser tests are passing on Windows, but I rebased over master locally a few times since the last push.

@mkarolin
Copy link
Collaborator Author

mkarolin commented Apr 2, 2019

Passed CI build with pinned brave-browser (https://staging.ci.brave.com/job/brave-core-build-pr/job/PR-2117/7/ and https://staging.ci.brave.com/job/brave-browser-build-pr/job/PR-3931/8/).

@mkarolin mkarolin marked this pull request as ready for review April 2, 2019 03:58
@mkarolin mkarolin requested a review from bridiver April 2, 2019 03:59
@mkarolin mkarolin mentioned this pull request Apr 2, 2019
Closed
19 tasks
bsclifton
bsclifton approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Verified CI looks good (everything is green / passing), also built/tested locally

@bsclifton
Copy link
Member

Great assist here too, @petemill 😄👍

@bsclifton bsclifton merged commit a6cf771 into master Apr 2, 2019
@bsclifton bsclifton deleted the 74.0.3729.40 branch April 2, 2019 06:04
mkarolin pushed a commit that referenced this pull request Apr 2, 2019
@bsclifton @mkarolin
Merge pull request #2117 from brave/74.0.3729.40
94881df 
Upgrade from Chromium 73.0.3683.75 to Chromium 74.0.3729.40
@mkarolin mkarolin mentioned this pull request Apr 2, 2019
Merged
mkarolin pushed a commit that referenced this pull request Apr 2, 2019
@bsclifton @mkarolin
Merge pull request #2117 from brave/74.0.3729.40
aa40247 
Upgrade from Chromium 73.0.3683.75 to Chromium 74.0.3729.40
@mkarolin mkarolin mentioned this pull request Apr 2, 2019
Merged
@darkdh darkdh mentioned this pull request Apr 3, 2019
Closed
19 tasks
mkarolin pushed a commit that referenced this pull request Apr 4, 2019
@bsclifton @mkarolin
Merge pull request #2117 from brave/74.0.3729.40
15ebcbe 
Upgrade from Chromium 73.0.3683.75 to Chromium 74.0.3729.40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bridiver bridiver Awaiting requested review from bridiver

Assignees

@mkarolin mkarolin

Labels
None yet
Projects
None yet
Milestone
0.65.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 73.0.3683.75 to Chromium 74.0.3729.40
4 participants
@mkarolin @bsclifton @darkdh @petemill