Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Reland C74 on master. #2103

Closed
wants to merge 4 commits into from
Closed

WIP: Reland C74 on master. #2103

wants to merge 4 commits into from

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Mar 28, 2019

Fixes brave/brave-browser#3502
Reverts #2088

This reverts commit f6cfa13, reversing
changes made to 6143676.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bsclifton
Copy link
Member

@mkarolin check out the commit by @simonhong here (I'll close my PR out):
#2047

@mkarolin
Copy link
Collaborator Author

mkarolin commented Apr 2, 2019

Closing in favor of #2117

@mkarolin mkarolin closed this Apr 2, 2019
@mkarolin mkarolin deleted the maxk-C74-reland branch November 8, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 73.0.3683.75 to Chromium 74.0.3729.40
3 participants