Issue 3920: Proxy requests for resources from storage.googleapis.com through the crlset redirector #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumde
force-pushed
the
storage_proxy_crlsets
branch
6 times, most recently
from
1f66594
to
418e9f1
Compare
jumde
commented
Mar 29, 2019
patches/chrome-VERSION.patch
Outdated
| @@ -8,4 +8,4 @@ index 3d9a560e26e43fb2da1332dff339c1039cfb1a3e..4050aa4ee4122124f154ceeff1e3ac83 | |||
| -BUILD=3683 | |||
| -PATCH=75 | |||
| +BUILD=65 | |||
| +PATCH=28 | |||
| +PATCH=0 | |||
There was a problem hiding this comment.
To-Do: Remove. Changed to get around CI build issues, will be fixed in master soon.
…through the crlset redirector
jumde
force-pushed
the
storage_proxy_crlsets
branch
from
8adcb5a
to
e1cdeaa
Compare
jumde
changed the title
This was referenced Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR builder passed here: https://staging.ci.brave.com/job/brave-browser-build-pr/job/PR-3929/
Description
fix: brave/brave-browser#3920
CRLSets on windows started requesting resources from storage.googleapis.com. We updated the redirector to proxy requests for these resources: brave/redirector@372e442
This PR updates the network delegate to proxy requests for storage.googleapis.com through the redirector.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
npm run test-securitypassesbrave://componentsand verify that CRLSet component version is non-zeroReviewer Checklist: