Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 73.0.3683.75 to Chromium 74.0.3729.40 #3931

Merged
merged 3 commits into from
Apr 2, 2019
Merged

Upgrade from Chromium 73.0.3683.75 to Chromium 74.0.3729.40 #3931

merged 3 commits into from
Apr 2, 2019

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Mar 28, 2019 •
edited by bsclifton
Loading

Fixes #3502, #3894, #3965
Related: brave/brave-core#2117

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@mkarolin mkarolin self-assigned this Mar 28, 2019
@mkarolin mkarolin mentioned this pull request Mar 31, 2019
Merged
19 tasks
@bsclifton
Copy link
Member

Blocked on brave/brave-core#2114

@bsclifton bsclifton mentioned this pull request Apr 1, 2019
Closed
16 tasks
@bsclifton bsclifton added this to the 0.65.x - Nightly milestone Apr 1, 2019
@mkarolin
Copy link
Contributor Author

mkarolin commented Apr 2, 2019

Passed CI build with pinned brave-browser (https://staging.ci.brave.com/job/brave-core-build-pr/job/PR-2117/7/ and https://staging.ci.brave.com/job/brave-browser-build-pr/job/PR-3931/8/).

@mkarolin mkarolin marked this pull request as ready for review April 2, 2019 03:57
bsclifton
bsclifton approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Verified CI looks good (everything is green / passing), also built/tested locally

@bsclifton bsclifton merged commit 45c313c into master Apr 2, 2019
@bsclifton bsclifton deleted the 74.0.3729.40 branch April 2, 2019 06:04
This was referenced Apr 2, 2019
Closed
Closed
mkarolin pushed a commit that referenced this pull request Apr 2, 2019
@bsclifton @mkarolin
Merge pull request #3931 from brave/74.0.3729.40
d8d6b1a 
Upgrade from Chromium 73.0.3683.75 to Chromium 74.0.3729.40
@mkarolin mkarolin mentioned this pull request Apr 2, 2019
Merged
mkarolin pushed a commit that referenced this pull request Apr 2, 2019
@bsclifton @mkarolin
Merge pull request #3931 from brave/74.0.3729.40
582009e 
Upgrade from Chromium 73.0.3683.75 to Chromium 74.0.3729.40
@mkarolin mkarolin mentioned this pull request Apr 2, 2019
Merged
mkarolin pushed a commit that referenced this pull request Apr 3, 2019
@bsclifton @mkarolin
Merge pull request #3931 from brave/74.0.3729.40
298d312 
Upgrade from Chromium 73.0.3683.75 to Chromium 74.0.3729.40
@darkdh darkdh mentioned this pull request Apr 3, 2019
Closed
16 tasks
mkarolin pushed a commit that referenced this pull request Apr 4, 2019
@bsclifton @mkarolin
Merge pull request #3931 from brave/74.0.3729.40
6e4d7e2 
Upgrade from Chromium 73.0.3683.75 to Chromium 74.0.3729.40
mkarolin pushed a commit that referenced this pull request Apr 5, 2019
@bsclifton @mkarolin
Merge pull request #3931 from brave/74.0.3729.40
bd368b0 
Upgrade from Chromium 73.0.3683.75 to Chromium 74.0.3729.40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bridiver bridiver Awaiting requested review from bridiver

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@mkarolin mkarolin

Labels
None yet
Projects
None yet
Milestone
0.65.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
3 participants
@mkarolin @bsclifton @darkdh