Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Reland C74 on master. #3919

Closed
wants to merge 4 commits into from
Closed

WIP: Reland C74 on master. #3919

wants to merge 4 commits into from

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Mar 28, 2019 •
edited by bsclifton
Loading

Fixes #3502

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

This was referenced Mar 28, 2019
Closed
Closed
@bsclifton
Copy link
Member

Closing in favor of #3931

@bsclifton bsclifton closed this Apr 1, 2019
@bsclifton bsclifton deleted the maxk-C74-reland branch August 6, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mkarolin mkarolin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkarolin @bsclifton @brave-browser-releases @darkdh