Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 128 to Chromium 129. #40204

Closed
mkarolin opened this issue Aug 1, 2024 · 3 comments · Fixed by brave/brave-core#24966
Closed

Upgrade from Chromium 128 to Chromium 129. #40204

mkarolin opened this issue Aug 1, 2024 · 3 comments · Fixed by brave/brave-core#24966

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Aug 1, 2024

Minor Chromium bump

Major Chromium bump

Upgrade from Chromium 128 to Chromium 129

https://chromium.googlesource.com/chromium/src/+log/128.0.6613.18...129.0.6628.3/?pretty=fuller&n=10000

QA tests

This is a major Chromium version bump, please do full passes.

Desktop affected areas:

  • Profile picker works correctly
  • Sync (generally works)
  • Tor (generally works)
  • Brave News (generally works)
  • All side panels can load and work (AI chat works in multiple tabs/windows)
  • Dropping multiple items on a tab in tabs bar works
  • Extensions menu (extensions button on the toolbar) looks correctly

iOS affected areas:
TBD

Android affected areas:

  • Brave ads notifications (double check that they work as expectred)
  • Tab switcher UI (double check there are no regressions)
  • Back button handling (double check it works as expected on web pages)
  • VPN or Leo subscription (double check it works as expected)
  • Leo web UI (double check no regressions here)
  • Close all tabs (double check it works as expected)
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 11, 2024

Verification PASSED on

Brave | 1.71.81 Chromium: 129.0.6668.31 (Official Build) nightly (64-bit)
-- | --
Revision | 33ed75506c3a0d5a964e5ca61494d6144c52fd7d
OS | Windows 10 Version 22H2 (Build 19045.4780)
Profile picker works correctly_PASSED
  1. Confirmed that user can create a new profile via Hamburger menu->More tools->Add a new profile menu option
  2. Confirmed that user can edit the profile to apply different theme
  3. Confirmed that user can delete the profile via profile manager
  4. Profile names are overlapping with Avatar, encountered the issue [C129 PR build] - Profiles names are overlapped with Avatars  #40964
Example Example Example Example Example
image image image image image
Sync (generally works)_PASSED
  • Verified the Sync cases from manual test run and ensured that Sync works as expected
Tor (generally works)_PASSED
  • Verified the TOR cases from manual test run and ensured that Tor works as expected
Brave News (generally works)_PASSED
  1. Confirmed that user can enable Brave News via NTP brave news welcome card
  2. Confirmed that user can view brave news feeds once the brave news is enabled
  3. Confirmed that user can disable/turn off brave news via customize dashboard settings via NTP
  4. Confirmed that user can re-enable brave news via customize dashboard settings via NTP
  5. Encountered and logged Click on <Back to Dashboard doesn't redirect to Dashboard settings, it just dismisses the dashboard settings modal #41022
Example Example Example Example
image image image image
All side panels can load and work (AI chat works in multiple tabs/windows)_PASSED

1. Leo AI

  • Confirmed that AI chat works as expected via Omnibox Leo entry point
  • Confirmed that AI chat works as expected via Sidebar Leo entry point
  • Confirmed that AI chat works as expected via Context menu Leo entry point
  • Confirmed that AI chat works as expected via Leo Toolbar button entry point
  • Confirmed that AI chat works as expected via App menu Leo entry point
  • Confirmed that AI chat works as expected via Omnibox command Leo entry point

2. Reading list:

  • Confirmed that click on reading list via side panel opens up the reading list with list of websites
  • Confirmed that sites can be added to reading list
  • Confirmed that websites can be segregated to reading and nonreading list
    image

3. Bookmarks:

  • Confirmed that click on Bookmarks sidebar panel opens up the bookmarks in the side panel
  • Confirmed that bookmarks can Edited/deleted
  • Confirmed that bookmarks can be reordered via sorting
Example Example Example
image image image
Dropping multiple items on a tab in tabs bar works_PASSED
  • Confirmed that multiple items drag and drop between windows and tabs works as expected on horizontal tab orientation
    horizontal tab drag and drop

  • Confirmed that multiple items drag and drop between windows and tabs works as expected on vertical tab orientation
    Vertical tabs drag and drop

Extensions menu (extensions button on the toolbar) looks correctly_PASSED
  • Confirmed that extensions button in toolbar looks correct.
  • Confirmed that click on extensions buttons shows the list of extensions
  • Confirmed that click on Extensions menu option via hamburger menu shows the brave://extensions/ page with list of extensions
  • Confirmed that click on any extension via extensions button in toolbar opens up the extension popup and confirmed that extension works as expected (e.g Adblock)
Example Example Example
image image image

Settings comparison

  • No new settings are added as part of CR 129 or Brave
  • A settings Improve search suggestions is renamed to Show search suggestions via brave://settings/search
  • A settings Show pinned tabs in all windows is removed from Beta and Nightly as part of Brave

Brave startup calls

  • Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
  • Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

@hffvld
Copy link
Contributor

hffvld commented Sep 11, 2024

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 15 AP41.240726.010 release-keys
Brave build: 1.70.101
Chromium: 128.0.6613.120 (Official Build) beta (64-bit) 

Filed follow-up issue #41034 and #41037

Brave ads notifications (double check that they work as expected)

ACTUAL RESULTS:

  • Verified that ad notifications received and stored in the notification drawer.
  • Verified that all actions on ad notifications works as expected, including dismissing and tapping and landing on ad page.
  • Verified that logs are recorded

Galaxy Tab S8

1 2 3
1 2 3
1 2 3
1 2 3

Pixel 7

1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
Tab switcher UI (double check there are no regressions)

ACTUAL RESULTS:

  • Verified that correct number of opened tabs is shown in tab switch button
  • Verified that all actions works as expected when tap/tap and hold tab switch button
  • Verified the same for both Normal and Private tabs

Galaxy Tab S8

1 2 3 4
1 2 3 4

Pixel 7

1 2 3 4 5 6
1 2 3 4 5 6
1 2 3 4 5 6
Back button handling (double check it works as expected on web pages)

ACTUAL RESULTS:

  • Verified that the short tap and long tap action on a Back button is working as expected
  • Verified that Forward button is working as expected

Galaxy Tab S8

1 2 3
1 2 3

Pixel 7

1 2 3
1 2 3
1 2 3
VPN or Leo subscription (double check it works as expected)

ACTUAL RESULTS:

  • Verified that new VPN subscription can be purchased and activated
  • Verified that active VPN subscription can be restored
  • Verified that active VPN subscription can be linked to the Web
  • Verified that Leo subscription can be purchased and activated
  • Verified that Leo subscription can be linked to the Web

Galaxy Tab S8

1 2 3 4 5
1 2 3 4 5
1 2 3 4 5

Pixel 7

1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
1 2 3 4 5
Leo web UI (double check no regressions here)

ACTUAL RESULTS:

  • Verified that Leo web UI looks as expected
  • Verified that all buttons works
  • Verified that voice query works
  • Verified that / tools works

Galaxy Tab S8

1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4

Pixel 7

1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4
Close all tabs (double check it works as expected)

ACTUAL RESULTS:

  • Verified that closing all tabs works as expected.
  • Verified that recently closed tabs can be restored for Normal, but not for Private tabs.

Galaxy Tab S8

1 2 3 4
1 2 3 4
1 2 3 4

Pixel 7

1 2 3 4
1 2 3 4
1 2 3 4

@kjozwiak
Copy link
Member

Labelling as QA/No & release-notes/exclude in favor of #41010.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment