Upgrade from Chromium 128 to Chromium 129 (uplift to 1.70.x). #25514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarolin
added
CI/run-network-audit
github-actions
bot
added
CI/storybook-url
mkarolin
force-pushed
the
cr129-1.70.x
branch
from
5590009
to
9c7de74
Compare
|
A Storybook has been deployed to preview UI for the latest push |
…ker_error Fix Debug build Linker issue
Upgrade from Chromium 128 to Chromium 129.
Fixes official Linux release build.
The build fails with:
09:30:10 > gn gen /home/ubuntu/workspace/brave-browser-build-linux-x64-nightly/src/out/Release --check
09:30:10
ERROR at //build/config/compiler/compiler.gni:324:3: Assertion failed.
09:30:10 assert(
09:30:10 ^-----
09:30:10 Can't do non-component builds at symbol_level=2 without use_debug_fission=true
09:30:10 See //build/config/compiler/compiler.gni:325:7:
09:30:10 symbol_level != 2 || current_toolchain != default_toolchain ||
09:30:10 ^-------------------------------------------------------------
09:30:10 This is where it was set.
09:30:10 See //BUILD.gn:13:1: whence it was imported.
09:30:10 import("//build/config/compiler/compiler.gni")
Due to Chromium change:
https://source.chromium.org/chromium/chromium/src/+/81024e91fddf6e045dcd9a8a04186c8cdbcbb4c0
commit 81024e91fddf6e045dcd9a8a04186c8cdbcbb4c0
Author: Nico Weber <thakis@chromium.org>
Date: Thu Aug 1 02:54:08 2024 +0000
Reland^2 "linux/build: Enable fission for (symbol_level = 2) release builds as well"
This is a reland of commit b7da3afa43ecb6a1a4839c4f91e798a6d72b221f
The CL got reverted for breaking android-official, and a comment
on the original review mentioned that it also broke a few cros bots
like arm-generic-cq.
For the reland, this now also allows non-fission static symbol_level 2
for android and chromeos.
Original change's description:
> Reland "linux/build: Enable fission for (symbol_level = 2) release builds as well"
>
> This is a reland of commit c031e3aa3a7a0ad71715655e140ba52ffa82a08d
> The reland removes an assert on macOS (where is_debug_fission isn't
> used -- darwin toolchains have always used something like fission,
> but under a different name).
>
> Original change's description:
> > linux/build: Enable fission for (symbol_level = 2) release builds as well
> >
> > Looks like full-symbol non-component builds are getting too big for
> > debug info even in release builds.
> >
> > Turn on fission by default on linux in release builds as well.
> >
> > This might affect official builds, where dump_syms etc might not
> > handle fission yet. If this is a problem, we'll have to fix this
> > at some point, but short-term we can not do this for official
> > builds in that case. (zequanwu@ says CrOS enabled fission already,
> > encountered dump_syms issues, and those already got fixed.
> > And a linux-official try run is green. We'll see!)
> >
> > (Component builds don't need fission yet, but for simplicity I'm
> > enabling fission independent of is_component_build.)
> >
> > Bug: 353915727
mkarolin
force-pushed
the
cr129-1.70.x
branch
from
f216de0
to
e8fa615
Compare
|
A Storybook has been deployed to preview UI for the latest push |
../../brave/browser/ui/brave_rewards/rewards_panel_coordinator.h:11:10: fatal error: 'brave/components/brave_rewards/common/mojom/rewards_panel.mojom.h' file not found
11 | #include "brave/components/brave_rewards/common/mojom/rewards_panel.mojom.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Upgrade from Chromium 129.0.6668.31 to Chromium 129.0.6668.42.
|
A Storybook has been deployed to preview UI for the latest push |
Chromium change: https://source.chromium.org/chromium/chromium/src/+/e86c3572f7012a64517e54c098984c0d44afe1f6 [Android] Use SettingsLauncherFactory directly from settings Fragments Also add SettingsLauncherFactory#setInstanceForTesting(). Clean up passing around of the SettingsLauncher to Fragments. Low-Coverage-Reason: LARGE_SCALE_REFACTOR Bug: 354019554
kjozwiak
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#40451
Resolves brave/brave-browser#40204
Resolves brave/brave-browser#39211
Resolves brave/brave-browser#40982
Resolves brave/brave-browser#41010
Resolves brave/brave-browser#40990
Resolves brave/brave-browser#41039
Uplift from: #24966
Uplift from: #25126
Uplift from: #25526
Uplift from: #25528
Uplift from: #25522
Uplift from: #25549
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: