Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CR129 - Redundant settings Use secure DNS and Select DNS provider under brave://settings/security #40989

Closed
1 of 6 tasks
GeetaSarvadnya opened this issue Sep 11, 2024 · 5 comments · Fixed by brave/brave-core#25521
Closed
1 of 6 tasks

CR129 - Redundant settings Use secure DNS and Select DNS provider under brave://settings/security #40989

GeetaSarvadnya opened this issue Sep 11, 2024 · 5 comments · Fixed by brave/brave-core#25521
Assignees
@simonhong
Labels
Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue feature/settings OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/blocking release-notes/exclude repros-on-chrome
Milestone
1.70.x - Release

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #40204

CR129 - Redundant settings Use secure DNS and Select DNS provider under brave://settings/security

Steps to reproduce

  1. NA

Actual result

image

Expected result

There should be one set of Use secure DNS and Select DNS provider under brave://settings/security

image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.71.81 Chromium: 129.0.6668.31 (Official Build) nightly (64-bit)
Revision 33ed75506c3a0d5a964e5ca61494d6144c52fd7d
OS Windows 10 Version 22H2 (Build 19045.4780)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @brave/qa-team @rebron @mkarolin @simonhong
@simonhong simonhong self-assigned this Sep 11, 2024
@simonhong
Copy link
Member

checking

simonhong added a commit to brave/brave-core that referenced this issue Sep 11, 2024
@simonhong
Hide redundant settings-secure-dns settings
b3c00dc 
fix brave/brave-browser#40989
@simonhong simonhong mentioned this issue Sep 11, 2024
Merged
24 tasks
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Sep 11, 2024
Closed
@mkarolin
Copy link
Contributor

mkarolin commented Sep 11, 2024 •
edited
Loading

I can see the same in Chrome Beta (129.0.6668.29). Filed upstream issue https://issues.chromium.org/issues/365884462

@mkarolin mkarolin mentioned this issue Sep 11, 2024
Merged
24 tasks
simonhong added a commit to brave/brave-core that referenced this issue Sep 12, 2024
@simonhong
Hide redundant settings-secure-dns settings
0b32091 
fix brave/brave-browser#40989
@rebron rebron added Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue repros-on-chrome labels Sep 12, 2024
@rebron rebron added this to the 1.70.x - Release milestone Sep 12, 2024
simonhong added a commit to brave/brave-core that referenced this issue Sep 13, 2024
@simonhong
Fixed duplicated secure dns settings
8a8e97a 
fix brave/brave-browser#40989

It's upstream issue and applied upstream fix in advance.
https://chromium-review.googlesource.com/c/chromium/src/+/5857984
jagadeshjai pushed a commit to jagadeshjai/brave-core that referenced this issue Sep 14, 2024
@simonhong @jagadeshjai
Hide redundant settings-secure-dns settings (brave#25521)
d679b25 
Fixed duplicated secure dns settings

fix brave/brave-browser#40989

It's upstream issue and applied upstream fix in advance.
https://chromium-review.googlesource.com/c/chromium/src/+/5857984
@kjozwiak
Copy link
Member

Added QA/Bocked as this was fixed via brave/brave-core#25521 but still needs an uplift. @mkarolin mentioned we might get the above via one of the C129 but we'll uplift just in case. Once brave/brave-core#25521 has been uplifted, we'll remove the QA/Blocked 👍

This was referenced Sep 16, 2024
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.70.113 or higher for 1.70.x verification 👍

@MadhaviSeelam
Copy link

MadhaviSeelam commented Sep 16, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.70.113 Chromium: 129.0.6668.42 (Official Build) (64-bit)
-- | --
Revision | e73406d8277b78a1d8f3f2f82bbc6babed537f7f
OS | Windows 11 Version 23H2 (Build 22631.4169)

Confirmed single entry of Use secure DNS and Select DNS provider under brave://settings/security is shown

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue feature/settings OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/blocking release-notes/exclude repros-on-chrome
Projects
Settings
Status: Completed
Milestone
1.70.x - Release
Development

Successfully merging a pull request may close this issue.

Hide redundant settings-secure-dns settings brave/brave-core
7 participants
@kjozwiak @rebron @simonhong @LaurenWags @GeetaSarvadnya @mkarolin @MadhaviSeelam