-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide redundant settings-secure-dns settings #25521
Conversation
The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "secure" and so security team members have been added as reviewers to take a look. |
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
9fc47e3
to
0b32091
Compare
fix brave/brave-browser#40989 It's upstream issue and applied upstream fix in advance. https://chromium-review.googlesource.com/c/chromium/src/+/5857984
0b32091
to
8a8e97a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
Fixed duplicated secure dns settings fix brave/brave-browser#40989 It's upstream issue and applied upstream fix in advance. https://chromium-review.googlesource.com/c/chromium/src/+/5857984
Verification PASSED on
Using the STR/Cases outlined via brave/brave-browser#40989 (comment), ensured that the redundant
|
Uplift of #25521 (squashed) to beta
Uplift of #25521 (squashed) to release
fix brave/brave-browser#40989
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See the linked issue