Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when closing 'Share Rewards Internals' dialog #40819

Closed
2 of 5 tasks
Uni-verse opened this issue Sep 3, 2024 · 2 comments · Fixed by brave/brave-core#25467
Closed
2 of 5 tasks

Crash when closing 'Share Rewards Internals' dialog #40819

Uni-verse opened this issue Sep 3, 2024 · 2 comments · Fixed by brave/brave-core#25467
Assignees
Labels
bug crash feature/rewards OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPhone QA/Yes regression release-notes/exclude

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 3, 2024

Description

Closing the dialog will cause crash everytime. Regression in 1.69

Steps to reproduce

  1. New install
  2. Enable Brave Rewards
  3. Open hamburger menu -> Settings -> Brave Rewards
  4. Tap on Rewards Internals at the bottom
  5. Tap on the share icon (top right)
  6. Close the dialog by pressing back button

Actual result

RPReplay_Final1725373956.mov

Expected result

No crash

Reproduces how often

Easily reproduced

Brave version

1.69 - Reproducible
1.68.1 - Not reproducible

Device/iOS version

iPhone / IOS 17

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@kjozwiak
Copy link
Member

kjozwiak commented Sep 8, 2024

The above requires 1.69.167 or higher for 1.69.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 9, 2024
@hffvld
Copy link
Contributor

hffvld commented Sep 9, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.6.1
Brave build: 1.69 (167)
BraveCore: 1.69.167 (128.0.6613.127)

STEPS:

  1. Follow the STR/TP from Crash when closing 'Share Rewards Internals' dialog #40819 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that Brave is not crashing when sharing Rewards Internals.

2024-09-09_09-26-34.mp4

@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug crash feature/rewards OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - iPhone QA/Yes regression release-notes/exclude
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants