Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix crash when cleaning up rewards internals sharables #25467

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

kylehickinson
Copy link
Collaborator

This cleanup call can be made from deinit which means that we can't access self within the async task

Resolves brave/brave-browser#40819

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This cleanup call can be made from `deinit` which means that we can't access `self` within the async task
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Sep 6, 2024
@kylehickinson kylehickinson self-assigned this Sep 6, 2024
@kylehickinson kylehickinson requested a review from a team as a code owner September 6, 2024 16:55
@kylehickinson kylehickinson merged commit 0fc1319 into master Sep 6, 2024
18 checks passed
@kylehickinson kylehickinson deleted the ios-share-crash-fix branch September 6, 2024 18:16
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Sep 6, 2024
brave-builds added a commit that referenced this pull request Sep 6, 2024
brave-builds added a commit that referenced this pull request Sep 6, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Sep 8, 2024

Verification PASSED on iPhone 6 running iOS 17.6.1 using the following build(s):

Brave | 1.71.68 Chromium: 128.0.6613.120 (Official Build) nightly (64-bit)
--- | ---
Revision | 58cc51123655...
OS | iOS

Using the STR/Cases outlined via brave/brave-browser#40819 (comment), reproduced the original problem with 1.71.66 Chromium: 128.0.6613.120 as per the following:

RPReplay_Final1725837453.MP4

Using the same STR/Cases used above to reproduce the issue, ensured that Brave wasn't crashing with 1.71.68 Chromium: 128.0.6613.120 as per the following:

RPReplay_Final1725837730.MP4

kjozwiak pushed a commit that referenced this pull request Sep 8, 2024
kjozwiak pushed a commit that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when closing 'Share Rewards Internals' dialog
3 participants