Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave-browser package should depend on brave-keyring #4205

Closed
fmarier opened this issue Apr 23, 2019 · 2 comments · Fixed by brave/brave-core#2338
Closed

brave-browser package should depend on brave-keyring #4205

fmarier opened this issue Apr 23, 2019 · 2 comments · Fixed by brave/brave-core#2338
Assignees
@fmarier
Labels
OS/Linux QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.66.x - Release ...

Comments

@fmarier
Copy link
Member

fmarier commented Apr 23, 2019 •
edited by kjozwiak
Loading

Test Plan

Original Issue

We should require the brave-keyring package when installing brave-browser on Linux in order to ensure that our package/repo signing key is up-to-date.

Currently the brave-keyring package only covers the release channel.

Once that's done and has made it all the way to release, we can simply our official installation instructions.
@fmarier fmarier self-assigned this Apr 23, 2019
fmarier added a commit to brave/brave-core that referenced this issue Apr 24, 2019
@fmarier
Make stable brave-browser depend on brave-keyring
6a68c5d 
Fixes brave/brave-browser#4205.
@fmarier fmarier added the QA/Yes label Apr 24, 2019
@fmarier fmarier mentioned this issue Apr 24, 2019
Merged
28 tasks
@fmarier fmarier added this to the 0.66.x - Nightly milestone Apr 25, 2019
@fmarier
Copy link
Member Author

fmarier commented May 25, 2019

Once this makes it to release, we can update the Linux installation instructions to remove mentions of brave-keyring.

@kjozwiak kjozwiak mentioned this issue Jun 11, 2019
Closed
@LaurenWags LaurenWags mentioned this issue Jun 27, 2019
Closed
84 tasks
@srirambv
Copy link
Contributor

Verification passed on

Brave 0.65.121 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Linux

  • Verified running sudo apt install brave-browser installed the current stable release
    image

  • Verified removing brave-keyring uninstalls brave-browser as well
    image

Brave 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Linux

@LaurenWags LaurenWags mentioned this issue Jul 1, 2019
Closed
@mbacchi mbacchi mentioned this issue Jul 2, 2019
Closed
@pitsi pitsi mentioned this issue Jul 3, 2019
Closed
@TimothyDJones TimothyDJones mentioned this issue Apr 16, 2021
Open
@Zahrun Zahrun mentioned this issue Sep 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarier fmarier

Labels
OS/Linux QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.66.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Make stable brave-browser depend on brave-keyring brave/brave-core
3 participants
@fmarier @kjozwiak @srirambv