Make stable brave-browser depend on brave-keyring

[fmarier]

Fixes brave/brave-browser#4205.

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Windows
  • macOS
  • Linux
• Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
  • Windows
  • macOS
  • Linux
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection

Test Plan:

With packages on the release channel:

• try installing them without the brave-keyring package (e.g. apt install brave-browser)
  • the brave-keyring will be pulled in automatically
  • brave-browser can't be installed on its own
• remove brave-keyring (e.g. apt remote brave-keyring):
  • this also removes brave-browser

With packages on the beta or dev channels:

• try installing them without the brave-keyring:
  • it will work and brave-keyring won't be pulled in automatically
• install brave-keyring manually after brave-browser-beta
• remove brave-keyring
  • this will not remove brave-browser-beta

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[fmarier]

I inspected the .deb and .rpm manually and they both included the correct metadata.

I tried installing the generated release package on Fedora and it correctly pulled in the dependency:

$ dnf install /home/francois/brave-browser-0.66.18-1.x86_64.rpm 
Last metadata expiration check: 1:50:41 ago on Wed 24 Apr 2019 06:01:18 PM UTC.
Dependencies resolved.
================================================================================================================
 Package             Architecture Version            Repository                                            Size
================================================================================================================
Installing:
 brave-browser       x86_64       0.66.18-1          @commandline                                          72 M
Installing dependencies:
 brave-keyring       noarch       1.1-1.fc30         brave-browser-rpm-release.s3.brave.com_x86_64_        10 k

Transaction Summary
================================================================================================================
Install  2 Packages

Total size: 72 M
Total download size: 10 k
Installed size: 234 M
Is this ok [y/N]: 

I tried installing the generated .deb and it correctly failed due to a missing dependency:

$ dpkg -i /home/francois/devel/brave-browser/src/out/Release/brave-browser_0.66.18_amd64.deb 
Selecting previously unselected package brave-browser.
(Reading database ... 31124 files and directories currently installed.)
Preparing to unpack .../brave-browser_0.66.18_amd64.deb ...
Unpacking brave-browser (0.66.18) ...
dpkg: dependency problems prevent configuration of brave-browser:
 brave-browser depends on brave-keyring; however:
  Package brave-keyring is not installed.

dpkg: error processing package brave-browser (--install):
 dependency problems - leaving unconfigured
Processing triggers for mime-support (3.60ubuntu1) ...
Errors were encountered while processing:
 brave-browser

Then I rebuilt the packages on the beta channel this time:

$ npm run create_dist Release -- --debug_build=true --channel=beta

I was able to install both beta packages without brave-keyring:

$ dnf install /home/francois/brave-browser-beta-0.66.18-1.x86_64.rpm 
created by dnf config-manager from https://brave-browser-rpm-release.s3.brave.c  80 kB/s | 3.3 kB     00:00    
Fedora Modular 29 - x86_64                                                       33 kB/s |  16 kB     00:00    
Fedora Modular 29 - x86_64 - Updates                                             66 kB/s |  15 kB     00:00    
Fedora 29 - x86_64 - Updates                                                     49 kB/s |  16 kB     00:00    
Fedora 29 - x86_64                                                               46 kB/s |  16 kB     00:00    
Dependencies resolved.
================================================================================================================
 Package                          Architecture         Version                 Repository                  Size
================================================================================================================
Installing:
 brave-browser-beta               x86_64               0.66.18-1               @commandline                73 M

Transaction Summary
================================================================================================================
Install  1 Package

Total size: 73 M
Installed size: 240 M
Is this ok [y/N]: 

$ dpkg -i /home/francois/devel/brave-browser/src/out/Release/brave-browser-beta_0.66.18_amd64.deb 
Selecting previously unselected package brave-browser-beta.
(Reading database ... 31444 files and directories currently installed.)
Preparing to unpack .../brave-browser-beta_0.66.18_amd64.deb ...
Unpacking brave-browser-beta (0.66.18) ...
Setting up brave-browser-beta (0.66.18) ...
update-alternatives: using /usr/bin/brave-browser-beta to provide /usr/bin/x-www-browser (x-www-browser) in auto mode
update-alternatives: using /usr/bin/brave-browser-beta to provide /usr/bin/gnome-www-browser (gnome-www-browser) in auto mode
update-alternatives: using /usr/bin/brave-browser-beta to provide /usr/bin/brave-browser (brave-browser) in auto mode
Processing triggers for mime-support (3.60ubuntu1) ...

and hand-inspection showed the correct dependency metadata.

[mbacchi]

This is great!