Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire SaveRecurringTip through ledger #5152

Closed
NejcZdovc opened this issue Jul 4, 2019 · 1 comment · Fixed by brave/brave-core#2962
Closed

Wire SaveRecurringTip through ledger #5152

NejcZdovc opened this issue Jul 4, 2019 · 1 comment · Fixed by brave/brave-core#2962

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jul 4, 2019

Test Cases

Original Issue

We need to wire all UI triggered functions through ledger code. What SaveRecurringTip we save it directly into db.

Take example of GetRecurringTipsUI on how it should be done.

@NejcZdovc NejcZdovc added feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes release-notes/exclude dev-experience labels Jul 4, 2019
@cg505 cg505 self-assigned this Jul 18, 2019
cg505 added a commit to brave/brave-core that referenced this issue Jul 19, 2019
cg505 added a commit to brave/brave-core that referenced this issue Jul 19, 2019
@cg505 cg505 added this to the 0.69.x - Nightly milestone Jul 19, 2019
@cg505 cg505 modified the milestones: 0.69.x - Dev, 0.70.x - Nightly Jul 23, 2019
cg505 added a commit to brave/brave-core that referenced this issue Jul 26, 2019
cg505 added a commit to brave/brave-core that referenced this issue Jul 26, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 24, 2019

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Set 1 BAT
image

Changed to 5 BAT in Panel
image

Changed to 0 Bat in Panel
image

Verified the updated recurring monthly value in DB

Verified passed with

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Set initial recurring tip, it is reflected on brave://rewards:
Screen Shot 2019-09-26 at 5 16 24 PM

Updated recurring tip from panel:
Screen Shot 2019-09-26 at 5 16 40 PM

Update is reflected on brave://rewards:
Screen Shot 2019-09-26 at 5 16 49 PM

tmancey pushed a commit that referenced this issue Apr 9, 2020
Fixes ad notifications are not shown on Windows until a non ad notification has been authorized - 1.8.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants