rewire SaveRecurringTip through ledger #2962

cg505 · 2019-07-19T19:55:35Z

@kylehickinson These iOS changes build, but I didn't actually build them into a full build. If it's straightforward to make sure this doesn't break anything, that would be good to test.

Submitter Checklist:

Test Plan:

Enable rewards and go to a verified publisher.
Add a montly tip for the publisher.
Verify that you see the montly contribution in brave://rewards.
To back the the publisher page and open the wallet panel. Change the tip amount.
Verify that the new tip amount is show in brave://rewards.

Reviewer Checklist:

New files have MPL-2.0 license header.
Request a security/privacy review as needed.
Adequate test coverage exists to prevent regressions
Verify test plan is specified in PR before merging to source

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on.
All relevant documentation has been updated.

kylehickinson · 2019-07-19T20:02:30Z

vendor/brave-ios/Ledger/BATBraveLedger.mm

@@ -466,19 +466,20 @@ - (void)listRecurringTips:(void (NS_NOESCAPE ^)(NSArray<BATPublisherInfo *> *))c

 - (void)addRecurringTipToPublisherWithId:(NSString *)publisherId amount:(double)amount


We should add a completion block here that is called in the SaveRecurringTip callback. suggested declaration:

- (void)addRecurringTipToPublisherWithId:(NSString *)publisherId amount:(double)amount completion:(void (^)(BOOL success))completion

Needs to updated in header as well

kylehickinson · 2019-07-19T20:05:04Z

vendor/brave-ios/Ledger/BATBraveLedger.mm

+  info->value = amount;
+  info->date = [[NSDate date] timeIntervalSince1970];
+  ledger->SaveRecurringTip(std::move(info), ^(ledger::Result result){
+    if (result != ledger::Result::LEDGER_OK) {


completion block should be called above this line after adding it (seen in previous comment):

dispatch_async(dispatch_get_main_queue(), ^{ completion(result == ledger::Result::LEDGER_OK) });

edit: you don't need the dispatch_async to main queue, the database insertion callbacks are done on main queue already

kylehickinson

ios++

cg505 · 2019-07-23T23:15:27Z

tests pass, some CI issues only

ryanml

lgtm cc: @NejcZdovc

NejcZdovc · 2019-07-25T17:14:20Z

components/brave_rewards/browser/rewards_service_impl.cc

+
+void RewardsServiceImpl::OnRecurringTipSaved(
+    ledger::SaveRecurringTipCallback callback,
+    bool success) {
  for (auto& observer : observers_) {


this observers should be in OnSaveRecurringTipUI

NejcZdovc · 2019-07-25T17:14:44Z

components/brave_rewards/browser/rewards_service_impl.h

-                             const int amount) override;
+  void OnSaveRecurringTipUI(
+      SaveRecurringTipCallback callback,
+      int32_t result);


NejcZdovc · 2019-07-25T17:14:50Z

components/brave_rewards/browser/rewards_service_impl.h

-  void OnRecurringTipSaved(bool success);
+  void OnRecurringTipSaved(
+      ledger::SaveRecurringTipCallback callback,
+      bool success);


Resolves brave/brave-browser#5152.

cg505 · 2019-07-26T23:21:02Z

CI passes everything but Windows here: https://staging.ci.brave.com/job/brave-browser-build-pr/job/save-recurring-tip-refactor/9//flowGraphTable/ (windows failed due to a CI bug)
Triggerred another windows-only CI

kylehickinson

iOS++

cg505 · 2019-07-28T01:49:15Z

Windows CI pass for reference: https://staging.ci.brave.com/job/brave-browser-build-pr/job/save-recurring-tip-refactor/11//flowGraphTable/

cg505 added the feature/rewards label Jul 19, 2019

cg505 added this to the 0.69.x - Nightly milestone Jul 19, 2019

cg505 requested review from kylehickinson and NejcZdovc July 19, 2019 19:55

cg505 self-assigned this Jul 19, 2019

kylehickinson requested changes Jul 19, 2019

View reviewed changes

NejcZdovc force-pushed the save-recurring-tip-refactor branch from 16c2127 to 69bd936 Compare July 22, 2019 07:41

NejcZdovc previously approved these changes Jul 22, 2019

View reviewed changes

cg505 dismissed NejcZdovc’s stale review via d63795c July 23, 2019 17:04

cg505 force-pushed the save-recurring-tip-refactor branch 2 times, most recently from d63795c to 41cf16d Compare July 23, 2019 17:54

kylehickinson previously approved these changes Jul 23, 2019

View reviewed changes

cg505 requested a review from NejcZdovc July 23, 2019 20:52

cg505 modified the milestones: 0.69.x - Dev, 0.70.x - Nightly Jul 23, 2019

cg505 dismissed kylehickinson’s stale review via 49c6098 July 24, 2019 19:11

cg505 force-pushed the save-recurring-tip-refactor branch from 398da29 to 49c6098 Compare July 24, 2019 19:11

cg505 requested a review from ryanml July 24, 2019 22:01

ryanml previously approved these changes Jul 25, 2019

View reviewed changes

kylehickinson previously approved these changes Jul 25, 2019

View reviewed changes

NejcZdovc reviewed Jul 25, 2019

View reviewed changes

cg505 dismissed stale reviews from kylehickinson and ryanml via ce7ae91 July 25, 2019 22:31

cg505 force-pushed the save-recurring-tip-refactor branch 2 times, most recently from ce7ae91 to d80499f Compare July 26, 2019 00:17

cg505 and others added 2 commits July 26, 2019 14:27

rewire SaveRecurringTip through ledger

6ebd34a

Resolves brave/brave-browser#5152.

Fixup iOS

ad037c5

use ledger::Result in mojo SaveRecurringTip calls

c3b54cf

cg505 force-pushed the save-recurring-tip-refactor branch from d80499f to c3b54cf Compare July 26, 2019 21:34

NejcZdovc approved these changes Jul 26, 2019

View reviewed changes

kylehickinson approved these changes Jul 26, 2019

View reviewed changes

cg505 added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jul 26, 2019

NejcZdovc removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jul 27, 2019

NejcZdovc merged commit 36f6230 into master Jul 27, 2019

NejcZdovc deleted the save-recurring-tip-refactor branch July 27, 2019 06:55

NejcZdovc mentioned this pull request Jul 27, 2019

Wire SaveRecurringTip through ledger brave/brave-browser#5152

Closed

kylehickinson mentioned this pull request Jul 30, 2019

Update lib with call updates & ads notifications brave/brave-rewards-ios#143

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rewire SaveRecurringTip through ledger #2962

rewire SaveRecurringTip through ledger #2962

cg505 commented Jul 19, 2019 •

edited by NejcZdovc

Loading

kylehickinson Jul 19, 2019 •

edited

Loading

kylehickinson Jul 19, 2019

kylehickinson Jul 19, 2019

kylehickinson left a comment

cg505 commented Jul 23, 2019

ryanml left a comment •

edited

Loading

NejcZdovc Jul 25, 2019

NejcZdovc Jul 25, 2019

NejcZdovc Jul 25, 2019

cg505 commented Jul 26, 2019 •

edited

Loading

kylehickinson left a comment

cg505 commented Jul 28, 2019

		@@ -466,19 +466,20 @@ - (void)listRecurringTips:(void (NS_NOESCAPE ^)(NSArray<BATPublisherInfo > ))c

		- (void)addRecurringTipToPublisherWithId:(NSString *)publisherId amount:(double)amount

rewire SaveRecurringTip through ledger #2962

rewire SaveRecurringTip through ledger #2962

Conversation

cg505 commented Jul 19, 2019 • edited by NejcZdovc Loading

Submitter Checklist:

Test Plan:

Reviewer Checklist:

After-merge Checklist:

kylehickinson Jul 19, 2019 • edited Loading

Choose a reason for hiding this comment

kylehickinson Jul 19, 2019

Choose a reason for hiding this comment

kylehickinson Jul 19, 2019

Choose a reason for hiding this comment

kylehickinson left a comment

Choose a reason for hiding this comment

cg505 commented Jul 23, 2019

ryanml left a comment • edited Loading

Choose a reason for hiding this comment

NejcZdovc Jul 25, 2019

Choose a reason for hiding this comment

NejcZdovc Jul 25, 2019

Choose a reason for hiding this comment

NejcZdovc Jul 25, 2019

Choose a reason for hiding this comment

cg505 commented Jul 26, 2019 • edited Loading

kylehickinson left a comment

Choose a reason for hiding this comment

cg505 commented Jul 28, 2019

cg505 commented Jul 19, 2019 •

edited by NejcZdovc

Loading

kylehickinson Jul 19, 2019 •

edited

Loading

ryanml left a comment •

edited

Loading

cg505 commented Jul 26, 2019 •

edited

Loading