Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tab page has an extraneous zero #5710

Closed
cndouglas opened this issue Aug 18, 2019 · 4 comments · Fixed by brave/brave-core#3297
Closed

New tab page has an extraneous zero #5710

cndouglas opened this issue Aug 18, 2019 · 4 comments · Fixed by brave/brave-core#3297
Assignees
@cezaraugusto
Labels
bug feature/new-tab priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.0.0 - Release

Comments

@cndouglas
Copy link
Contributor

cndouglas commented Aug 18, 2019 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#3297

Description

On the new tab page, there is an extraneous zero between the stats and time.

It seems to be a part of the stats section because turning off "Show Brave Stats" makes the zero disappear.

Steps to Reproduce

  1. Open a new tab. You may want to disable the background image to see the zero easier.

Actual result:

Expected result:

There shouldn't be an extraneous zero.

Reproduces how often:

Always.

Brave version (brave://version info)

Brave | 0.71.15 Chromium: 76.0.3809.100 (Official Build) nightly (64-bit)
Revision | ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS | Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel? Yes.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Not applicable.
  • Does the issue resolve itself when disabling Brave Rewards? Not applicable.
  • Is the issue reproducible on the latest version of Chrome? Not applicable.

Miscellaneous Information:
@cezaraugusto
Copy link
Contributor

@cndouglas just tried with Version 0.71.37 Chromium: 76.0.3809.100 and can't repro anymore. could you please check again?

@cndouglas
Copy link
Contributor Author

Still happening with Brave 0.71.37 on macOS 10.14.x. One time it disappeared but then reappeared when I cleared all my top site tiles.

image

@cndouglas
Copy link
Contributor Author

cndouglas commented Aug 27, 2019 •
edited
Loading

@cezaraugusto Also can confirm it happens with a fresh profile:
image

cezaraugusto added a commit to brave/brave-core that referenced this issue Aug 29, 2019
@cezaraugusto
ensure topSites list rendering evaluate to null when its hidden
a9dcaaa 
fix brave/brave-browser#5710

There is a rendering issue for topSites that evaluates to false
when no topSite is available, which is being coerced to 0 by React.
This change ensures it evaluates to null instead,
not adding an extraneous output to NTP layout.
@cezaraugusto cezaraugusto mentioned this issue Aug 29, 2019
Merged
6 tasks
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 30, 2019
@bsclifton bsclifton added this to the 0.72.x - Nightly milestone Oct 1, 2019
@cezaraugusto cezaraugusto mentioned this issue Oct 3, 2019
Merged
@btlechowski
Copy link

btlechowski commented Oct 14, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.70.112 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3297

image

Verification passed on

Brave 0.71.94 Chromium: 77.0.3865.90 (Official Build) dev (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 0.71.103 Chromium: 78.0.3904.70 (Official Build) beta (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-10-25 at 2 53 35 PM

@kjozwiak kjozwiak mentioned this issue Nov 12, 2019
Closed
@NejcZdovc NejcZdovc mentioned this issue Nov 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/new-tab priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging a pull request may close this issue.

ensure topSites list rendering evaluate to null when its hidden brave/brave-core
7 participants
@cezaraugusto @bsclifton @rebron @cndouglas @LaurenWags @btlechowski @GeetaSarvadnya