Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.71.x] ensure topSites list rendering evaluate to null when its hidden #3594

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

cezaraugusto
Copy link
Contributor

uplift request for #3297
fix brave/brave-browser#5710 on 0.71.x

ensure topSites list rendering evaluate to `null` when its hidden
@cezaraugusto cezaraugusto added this to the 0.71.x - Dev milestone Oct 3, 2019
@cezaraugusto cezaraugusto requested a review from a team October 3, 2019 13:31
@cezaraugusto cezaraugusto self-assigned this Oct 3, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Oct 5, 2019

Restarting Linux due to npm run network-audit -- --output_path="src/out/Release/brave" failing as per https://staging.ci.brave.com/job/brave-browser-build-pr/job/ca-5710-71/1/execution/node/596/log/:

10:54:53  {"phase":0,"source":{"id":116,"type":9}]}
10:54:53                                         ^
10:54:53  
10:54:53  SyntaxError: Unexpected token ] in JSON at position 78276957
10:54:53      at JSON.parse (<anonymous>)
10:54:53      at start (/home/ubuntu/jenkins/workspace/rave-browser-build-pr_ca-5710-71/lib/start.js:144:23)
10:54:53      at Command.listener (/home/ubuntu/jenkins/workspace/rave-browser-build-pr_ca-5710-71/node_modules/commander/index.js:315:8)
10:54:53      at Command.emit (events.js:203:13)
10:54:53      at Command.parseArgs (/home/ubuntu/jenkins/workspace/rave-browser-build-pr_ca-5710-71/node_modules/commander/index.js:654:12)
10:54:53      at Command.parse (/home/ubuntu/jenkins/workspace/rave-browser-build-pr_ca-5710-71/node_modules/commander/index.js:474:21)
10:54:53      at Object.<anonymous> (/home/ubuntu/jenkins/workspace/rave-browser-build-pr_ca-5710-71/scripts/commands.js:155:4)
10:54:53      at Module._compile (internal/modules/cjs/loader.js:868:30)
10:54:53      at Object.Module._extensions..js (internal/modules/cjs/loader.js:879:10)
10:54:53      at Module.load (internal/modules/cjs/loader.js:731:32)
10:54:53  npm ERR! code ELIFECYCLE

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Oct 5, 2019
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.71.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are added and the associated issue is moved into the correct milestone.

@bsclifton bsclifton merged commit b1fce73 into 0.71.x Oct 7, 2019
@bsclifton bsclifton deleted the ca-5710-71 branch October 7, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants