Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Password creates file name labelled as Chrome Passwords #629

Closed
srirambv opened this issue Jul 23, 2018 · 1 comment · Fixed by brave/brave-core#3890 or #6778
Closed

Export Password creates file name labelled as Chrome Passwords #629

srirambv opened this issue Jul 23, 2018 · 1 comment · Fixed by brave/brave-core#3890 or #6778

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 23, 2018

Description

Export Password creates file name as Chrome Passwords

Steps to Reproduce

  1. Login to any site and save the password
  2. Go to chrome://settings/passwords and click on hamburger menu item on Save password
  3. Click export password, save file prompts and defaults the file name to Chrome Passwords

Actual result:

image

Expected result:

Should say Brave Passwords

Reproduces how often:

100%

Brave version (about:brave info)

0.50.14

Reproducible on current release:

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@srirambv srirambv added this to the Releasable builds milestone Jul 23, 2018
@bbondy bbondy modified the milestones: Releasable builds, Backlog Jul 26, 2018
@yrliou yrliou removed their assignment Nov 8, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 19, 2019
@simonhong simonhong self-assigned this Nov 6, 2019
@simonhong simonhong added this to the 0.74.x - Nightly milestone Nov 6, 2019
@btlechowski
Copy link

btlechowski commented Nov 28, 2019

Verification passed on

Brave 1.3.38 Chromium: 78.0.3904.108 (Official Build) nightly (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Ubuntu 18.04 LTS

Verified test plan from the description. Verified that the passwords are actually store in the file.

image

Verified passed with

Brave 1.3.87 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified STR from description, confirmed file contains password info.

Screen Shot 2020-01-09 at 4 11 06 PM

Verification passed n

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from description, confirmed file contains password info.
    image

@rebron rebron changed the title Export Password creates file name as Chrome Passwords Export Password creates file name labelled as Chrome Passwords Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment