Rebranding password_manager_strings.grdp #6778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
simonhong
force-pushed
the
rebranding_password_manager_strings
branch
2 times, most recently
from
e61eac7 to
4b125b1
Compare
simonhong
force-pushed
the
rebranding_password_manager_strings
branch
from
4b125b1 to
838d506
Compare
bridiver
reviewed
Nov 8, 2019
lib/l10nUtil.js
Outdated
| @@ -40,7 +40,9 @@ const braveBookmarksBarStringsPartPath = path.resolve(path.join(srcDir, 'brave', | |||
|
|
|||
| // src/components/components_strings.grd and any of its parts files. | |||
| const chromiumManagementStringsPartPath = path.resolve(path.join(srcDir, 'components', 'management_strings.grdp')) | |||
| const braveManagementStringsPartPath = path.resolve(path.join(srcDir, 'brave', 'chromium_src', 'components', 'management_strings.grdp')) | |||
| const braveManagementStringsPartPath = path.resolve(path.join(srcDir, 'brave', 'app', 'management_strings.grdp')) | |||
There was a problem hiding this comment.
these files should stay in components, they don't belong or make sense in app
Also, store generated management_strings.grpd to //brave/components
simonhong
force-pushed
the
rebranding_password_manager_strings
branch
from
838d506 to
02dcecb
Compare
bridiver
previously approved these changes
Nov 8, 2019
mkarolin
reviewed
Nov 8, 2019
lib/util.js
Outdated
Comment on lines
157
to
161
| autoGeneratedBraveToChromiumMapping[path.join(braveComponentsDir, 'components_brave_strings.grd')] = path.join(config.srcDir, 'components', 'components_brave_strings.grd') | ||
| autoGeneratedBraveToChromiumMapping[path.join(braveComponentsDir, 'components_strings.grd')] = path.join(config.srcDir, 'components', 'components_strings.grdp') | ||
| autoGeneratedBraveToChromiumMapping[path.join(braveComponentsDir, 'management_strings.grdp')] = path.join(config.srcDir, 'components', 'management_strings.grdp') | ||
| autoGeneratedBraveToChromiumMapping[path.join(braveComponentsDir, 'password_manager_strings.grdp')] = path.join(config.srcDir, 'components', 'password_manager_strings.grdp') | ||
| autoGeneratedBraveToChromiumMapping[path.join(braveComponentsDir, 'bookmark_bar_strings.grdp')] = path.join(config.srcDir, 'components', 'bookmark_bar_strings.grdp') |
There was a problem hiding this comment.
Nit: chromeComponentsDir is defined above.
simonhong
force-pushed
the
rebranding_password_manager_strings
branch
from
1c92cfd to
0b6151c
Compare
bridiver
approved these changes
Nov 9, 2019
mkarolin
pushed a commit
that referenced
this pull request
Dec 3, 2019
Rebranding password_manager_strings.grdp
mkarolin
pushed a commit
that referenced
this pull request
Dec 3, 2019
Rebranding password_manager_strings.grdp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, store generated management_strings.grpd to //brave/app.
fix #629
Submitter Checklist:
git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.