Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebranding password_manager_strings.grdp #3890

Merged
merged 2 commits into from
Nov 9, 2019

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Nov 6, 2019

Also, move management_strings.grdp to //brave/app.

fix brave/brave-browser#629
This should be merged with brave/brave-browser#6778 together.

Submitter Checklist:

Test Plan:

See the issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 0.74.x - Nightly milestone Nov 6, 2019
@simonhong simonhong requested a review from mkarolin November 6, 2019 04:12
@simonhong simonhong requested a review from bridiver as a code owner November 6, 2019 04:12
@simonhong simonhong self-assigned this Nov 6, 2019
@simonhong simonhong force-pushed the rebranding_password_manager_strings branch from 3181a51 to c06c042 Compare November 6, 2019 04:15
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong simonhong force-pushed the rebranding_password_manager_strings branch from c06c042 to 7048e2f Compare November 7, 2019 20:58
Also, move management_strings.grdp to //brave/components.
@simonhong simonhong force-pushed the rebranding_password_manager_strings branch from 7048e2f to 9c6e861 Compare November 8, 2019 06:25
@simonhong simonhong requested a review from mkarolin November 8, 2019 06:27
@mihaiplesa mihaiplesa added CI/skip-android Do not run CI builds for Android CI/skip-linux labels Nov 8, 2019
@mihaiplesa
Copy link
Collaborator

Has passed for Android, Linux, Windows so applied skip labels and will need to be re-built only on iOS and macOS (unless no new changes pushed).

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@simonhong simonhong added the CI/skip-ios Do not run CI builds for iOS label Nov 9, 2019
@simonhong simonhong merged commit 613647e into master Nov 9, 2019
@simonhong simonhong deleted the rebranding_password_manager_strings branch November 9, 2019 23:11
mkarolin pushed a commit that referenced this pull request Dec 3, 2019
mkarolin pushed a commit that referenced this pull request Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Password creates file name labelled as Chrome Passwords
4 participants