Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

widevine not working on certain websites (Netflix/Amazon Prime) #6497

Closed
kjozwiak opened this issue Oct 16, 2019 · 3 comments · Fixed by brave/brave-core#3718
Closed

widevine not working on certain websites (Netflix/Amazon Prime) #6497

kjozwiak opened this issue Oct 16, 2019 · 3 comments · Fixed by brave/brave-core#3718
Assignees
@simonhong
Labels
bug OS/macOS OS/Windows plugin/Widevine QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release/blocking release-notes/exclude
Milestone
0.70.x - Release

Comments

@kjozwiak
Copy link
Member

Description

Looks like Netflix and other websites that are using Widevine stopped working with builds using 78.0.3904.50. Examples:

  • Netflix - currently broken and doesn't play media
  • Amazon Prime Video - currently broken and doesn't play media
  • YouTube - seems to be working

Steps to Reproduce

Case #1

  1. launch 0.70.117 CR: 78.0.3904.50 and login into netflix.com
  2. install Widevine and attempt to play content

Case #2

  1. launch 0.70.117 CR: 78.0.3904.50 and login into https://www.primevideo.com
  2. install Widevine and attempt to play content

Actual result:

Screen Shot 2019-10-16 at 2 31 03 AM

Screen Shot 2019-10-16 at 2 33 30 AM

Screen Shot 2019-10-16 at 3 07 14 AM

Expected result:

Netflix should be working and playing content without any issues/errors.

Reproduces how often:

100% reproducible when using the above STR.

Brave version (brave://version info)

Brave 0.70.117 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS macOS Version 10.14.6 (Build 18G95)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @rebron @bsclifton @brave/legacy_qa
@kjozwiak kjozwiak added this to the 0.70.x - Release milestone Oct 16, 2019
@simonhong simonhong self-assigned this Oct 16, 2019
@simonhong simonhong mentioned this issue Oct 16, 2019
Merged
32 tasks
@btlechowski
Copy link

@kjozwiak does page reload fixes the issue?

Similar issue #4646

Not reproducible on Ubuntu. Maybe because on Linux user is forced to restart browser after installing Widevine.

Brave 0.70.117 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Linux

image

@simonhong
Copy link
Member

@btlechowski No, reloading doesn't help. This is Widevine VMP(Verified Media Path) issue.
And VMP is not enabled on linux. So, linux should not have this issue.

bsclifton pushed a commit to brave/brave-core that referenced this issue Oct 21, 2019
@bridiver @bsclifton
Fixes our use of GOOGLE_CHROME_BUILD
cf9cd47 
Fixes brave/brave-browser#6496
Fixes brave/brave-browser#6497

In places we reused GOOGLE_CHROME_BUILD by defining it in particular
files (either via chromium_src or by patching). GOOGLE_CHROME_BUILD is
being phased out in favor of BUILDFLAG(GOOGLE_CHROME_BRANDING). This fix
updates our uses where the transition has already occurred.

Chromium changes:

Overall issue tracker:
https://bugs.chromium.org/p/chromium/issues/detail?id=961769&can=2&q=961769

Some specific changes:

https://chromium.googlesource.com/chromium/src/+/0cc7112944131e379a141d8734a77cb50b97e1d5

commit 0cc7112944131e379a141d8734a77cb50b97e1d5
Author: Nico Weber <thakis@chromium.org>
Date:   Mon Jul 29 17:30:40 2019 +0000

    Add BUILDFLAG(GOOGLE_CHROME_BRANDING) and start using it in a few places.

    Also fix the definition of CHROMIUM_BRANDING; putting a negated condition
    there doesn't work. Thanks to Yngve Petterson for pointing that out.

    No behavior change.

    Bug: 961769

https://chromium.googlesource.com/chromium/src/+/356b304474c643e8064db763b97101100597bddd

commit 356b304474c643e8064db763b97101100597bddd
Author: Nico Weber <thakis@chromium.org>
Date:   Fri Aug 23 15:30:41 2019 +0000

    Remove all references to GOOGLE_CHROME_BUILD in components/

    Bug: 961769
This was referenced Oct 22, 2019
Merged
Merged
Merged
@bsclifton bsclifton mentioned this issue Oct 22, 2019
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Oct 23, 2019 •
edited by kjozwiak
Loading

Verified passed with

Brave 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified Widevine install for Netflix on clean profile. Confirmed able to stream video without error.
  • Verified Widevine install for Amazon Prime on clean profile. Confirmed able to stream video without error.
  • Verified Widevine install for YouTube on clean profile. Confirmed able to stream video without error.

Verification PASSED on Win 10 x64 using the following build:

Brave 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Windows 10 OS Version 1809 (Build 17763.805)
  • Verified Widevine install for Netflix on clean profile. Confirmed able to stream video without error.
  • Verified Widevine install for Amazon Prime on clean profile. Confirmed able to stream video without error.
  • Verified Widevine install for YouTube on clean profile. Confirmed able to stream video without error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug OS/macOS OS/Windows plugin/Widevine QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release/blocking release-notes/exclude
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging a pull request may close this issue.

Update wrong GOOGLE_CHROME_BUILD usage brave/brave-core
4 participants
@kjozwiak @simonhong @LaurenWags @btlechowski