Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wrong GOOGLE_CHROME_BUILD usage (uplift to 0.70.x) #3767

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Update wrong GOOGLE_CHROME_BUILD usage (uplift to 0.70.x) #3767

merged 1 commit into from
Oct 22, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 22, 2019 •
edited by bsclifton
Loading

Uplift of #3718
Fixes brave/brave-browser#6497
Fixes brave/brave-browser#6496

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Oct 22, 2019
@brave-builds brave-builds added this to the 0.70.x - Release milestone Oct 22, 2019
@bsclifton bsclifton requested review from a team and removed request for bridiver, bbondy, kjozwiak, bsclifton, rebron and srirambv October 22, 2019 00:13
@kjozwiak
Copy link
Member

@bsclifton looks like lint failed on android, iOS, linux. macOS:

Should we restart these PR's on android, iOS, linux. macOS or is this a known intermittent issue?

@bsclifton
Copy link
Member

@kjozwiak we're OK skipping. It's a known issue captured here: brave/brave-browser#6434

It doesn't always seem to happen, which is weird

kjozwiak
kjozwiak approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.70.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@bsclifton bsclifton merged commit 820cf25 into 0.70.x Oct 22, 2019
@bsclifton bsclifton deleted the pr3718_fix_vmp_not_working_0.70.x branch October 22, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @bsclifton @brave-browser-releases