Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "no tokens" messaging on BR panel for BAT Points regions #6604

Closed
mattmcalister opened this issue Oct 24, 2019 · 2 comments · Fixed by brave/brave-core#3849
Closed

Comments

@mattmcalister
Copy link

mattmcalister commented Oct 24, 2019

For locales where BAT Points are required, when wallet Balance = 0, change the list of "3 ways to fill your wallet":

  1. Delete the heading and the 3 bullets

  2. Replace it with a sentence -> "Look for ad notifications as you continue to use Brave. Your BAT Points balance will increase with each ad you view."

Reason: Users can't add funds, and we are unlikely to issue free token grants.

Screen Shot 2019-10-24 at 12 53 05

@rebron
Copy link
Collaborator

rebron commented Oct 30, 2019

Closing. Duplicate of #6654

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 11, 2019

Verification passed on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

Verification passed on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS

image

Verification PASSED on macOS 10.15.1 x64 using the following build:

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.15.1 (Build 19B88)

Screen Shot 2019-11-11 at 10 43 34 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment