Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAT Points updates for unsupported regions #3751

Merged
merged 1 commit into from
Oct 24, 2019
Merged

BAT Points updates for unsupported regions #3751

merged 1 commit into from
Oct 24, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 19, 2019

Fixes brave/brave-browser#6480
Fixes brave/brave-browser#6577

This implements the BAT Points language for regions where only anon wallets are allowed.

Screen Shot 2019-10-18 at 9 36 32 PM

Submitter Checklist:

Test Plan:

  1. Enable rewards
  2. Wait for initilization
  3. Close browser
  4. Open Preferences file and search for countryid_at_install
  5. Replace current value with 19024
  6. Restart Browser
  7. Claim a grant
  8. Confirm that the grant claim shows "BAT Points" instead of BAT
  9. Tip a couple of sites
  10. Confirm that the wallet view in brave://rewards adheres to spec for bat points
  11. Confirm that the panel adheres to spec for bat points

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 0.73.x - Nightly milestone Oct 19, 2019
@ryanml ryanml requested review from NejcZdovc and a team October 19, 2019 03:07
@ryanml ryanml self-assigned this Oct 19, 2019
@ryanml ryanml force-pushed the bat-points branch 6 times, most recently from 2c52796 to 1425eca Compare October 23, 2019 01:00
@NejcZdovc
Copy link
Contributor

CI passed except of lint because of a known thing. Will restart CI just for mac as CI lint should be fixed now

@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Oct 23, 2019
@NejcZdovc NejcZdovc removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Oct 23, 2019
@ryanml ryanml force-pushed the bat-points branch 2 times, most recently from decd30d to 490d48e Compare October 23, 2019 19:55
@ryanml ryanml requested a review from NejcZdovc October 23, 2019 19:55
@wmazoni
Copy link

wmazoni commented Oct 24, 2019

When will BAT come to Brazil?

Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing on non related tests.

@NejcZdovc NejcZdovc merged commit c562531 into master Oct 24, 2019
@NejcZdovc NejcZdovc deleted the bat-points branch October 24, 2019 15:37
bsclifton pushed a commit that referenced this pull request Oct 30, 2019
BAT Points updates for unsupported regions
bsclifton pushed a commit that referenced this pull request Oct 30, 2019
BAT Points updates for unsupported regions
@kjozwiak
Copy link
Member

kjozwiak commented Oct 31, 2019

Went through the following verifications using 0.73.42 CR: 78.0.3904.70 before approving . and uplifting both #3810 and #3809:

There's certain parts of the UI that still mention BAT & Tokens but these will be addressed via the following issues:

Went through the following UI and ensured that BAT Points was being used as per https://docs.google.com/document/d/1Vf9rFeSEPx8KbZYzw_rCyMq8iv5AExU0fhnv3Q6bZe0/edit#heading=h.n61l82sr1zxg:

Screen Shot 2019-10-30 at 2 44 15 PM

Screen Shot 2019-10-30 at 2 44 35 PM

Screen Shot 2019-10-30 at 21 02 13

Screen Shot 2019-10-30 at 3 43 03 PM

Screen Shot 2019-10-30 at 3 42 38 PM

Screen Shot 2019-10-30 at 3 04 19 PM

Screen Shot 2019-10-30 at 2 48 06 PM

Screen Shot 2019-10-30 at 21 21 42

Screen Shot 2019-10-30 at 21 21 54

Screen Shot 2019-10-30 at 4 12 06 PM

Screen Shot 2019-10-30 at 3 46 07 PM

Screen Shot 2019-10-30 at 22 07 09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

details translation missing in Rewards panel BAT Points support
4 participants