Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BAT Points updates for unsupported regions (0.71) #3809

Merged
merged 1 commit into from
Nov 1, 2019
Merged

BAT Points updates for unsupported regions (0.71) #3809

merged 1 commit into from
Nov 1, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 29, 2019

@ryanml ryanml added this to the 0.71.x - Beta milestone Oct 29, 2019
@ryanml ryanml requested a review from a team October 29, 2019 18:05
@ryanml ryanml self-assigned this Oct 29, 2019
@ryanml ryanml removed the request for review from NejcZdovc October 29, 2019 18:06
@kjozwiak
Copy link
Member

Restarting as it doesn't look like it ran correctly and timed out after ~6mins.

@kjozwiak
Copy link
Member

Looks like Win x64 failed due to the following error as per https://ci.brave.com/job/brave-browser-build-pr/job/uplift-3751-71/1/execution/node/399/log/:

00:33:29 WindowsError: [Error 123] The filename, directory name, or volume label syntax is incorrect: 'C:\\Users\x07dministrator'

This will need to be rebased and restarted now that the above error was fixed with brave/brave-browser#6672.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Oct 30, 2019
@NejcZdovc @bsclifton
Merge pull request #3751 from brave/bat-points
6034266 
BAT Points updates for unsupported regions
@kjozwiak kjozwiak mentioned this pull request Oct 31, 2019
Merged
32 tasks
kjozwiak
kjozwiak approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.71.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis finally passed after several retries. I also QA'd #3751 (comment) and everything was working was expected 👍

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 7c27f49 into 0.71.x Nov 1, 2019
@kjozwiak kjozwiak deleted the uplift-3751-71 branch November 1, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@ryanml ryanml

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/rewards
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanml @kjozwiak @NejcZdovc