Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome page slides are not centered #6846

Closed
cezaraugusto opened this issue Nov 8, 2019 · 8 comments · Fixed by brave/brave-core#3940
Closed

Welcome page slides are not centered #6846

cezaraugusto opened this issue Nov 8, 2019 · 8 comments · Fixed by brave/brave-core#3940

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Nov 8, 2019

Screen Shot 2019-11-08 at 3 21 35 PM

Bug affects 0.72.x onwards.

Test Plan

  1. Navigate through slides
  2. Assert slide content is not properly aligned

Jumping content (from @petemill)

  1. Open brave://welcome
  2. Move to slide 2
  3. Observe position of content
  4. Hover over 'import' button
  5. Observe content jumps to a different position
@cezaraugusto cezaraugusto self-assigned this Nov 8, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue Nov 8, 2019
Content was not centered causing a bad UI. This commit fix that.

fix brave/brave-browser#6846
cezaraugusto added a commit to brave/brave-core that referenced this issue Nov 8, 2019
Content was not centered causing a bad UI. This commit fix that.

fix brave/brave-browser#6846
cezaraugusto added a commit to brave/brave-core that referenced this issue Nov 8, 2019
Content was not centered causing a bad UI. This commit fix that.

fix brave/brave-browser#6846
@bsclifton bsclifton added this to the 0.74.x - Nightly milestone Nov 11, 2019
@bsclifton
Copy link
Member

@cezaraugusto can you add a test plan? What versions are affected? I tried this in 0.71.x and can't reproduce

@cezaraugusto
Copy link
Contributor Author

@bsclifton updated the comment. bug is present only in 0.72.x onwards

@antonok-edm
Copy link
Collaborator

Also noticing that it quickly jumps to the intended location when moving the mouse nearby

6846

cezaraugusto added a commit to brave/brave-core that referenced this issue Nov 12, 2019
Content was not centered causing a bad UI. This commit fix that.

fix brave/brave-browser#6846
cezaraugusto added a commit to brave/brave-core that referenced this issue Nov 12, 2019
Content was not centered causing a bad UI. This commit fix that.

fix brave/brave-browser#6846
cezaraugusto added a commit to brave/brave-core that referenced this issue Nov 12, 2019
Content was not centered causing a bad UI. This commit fix that.

fix brave/brave-browser#6846
@LaurenWags
Copy link
Member

In addition to @antonok-edm comment in #6846 (comment) sometimes the content jumps to the intended location when interacting with the content via tab (as in #5504 ).

Brave 1.1.2 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 18, 2019

Encountered and reproduced #6846 (comment) on windows 10 x64 - Brave beta1.1.4

@bsclifton
Copy link
Member

Marked as release-notes/exclude because I believe the problem isn't on 1.0.x

@btlechowski
Copy link

Not in 1.1.18, waiting for another build.

@kjozwiak
Copy link
Member

kjozwiak commented Dec 9, 2019

Verification PASSED on macOS 10.15.1 x64 using the following build:

Brave 1.1.19 Chromium: 79.0.3945.70 (Official Build) (64-bit)
Revision 65868db27916cebde51fc2465c9b34761e6383e2-refs/branch-heads/3945@{#869}
OS macOS Version 10.15.1 (Build 19B88)
  • reproduced the original issue using 1.1.18 Chromium: 79.0.3945.56
  • went through and verified the original STR as per Welcome page slides are not centered #6846 (comment)
  • ensured that the brave://welcome page is aligned on initial launch
  • ensured that the brave://welcome page is aligned when navigating through the different pages
  • ensured that each page is correctly aligned when interacting with buttons (Import, Set Default etc..)
  • ensured alignment looks correct when navigating through each page using both Next & bullets
  • ensured that resizing the brave://welcome window doesn't cause any alignment issues
  • ensured that all the links are working as expected
  • ensured the above STR/cases work as expected when using a secondary monitor

Verification passed on

Brave 1.1.19 Chromium: 79.0.3945.70 (Official Build) (64-bit)
Revision 65868db27916cebde51fc2465c9b34761e6383e2-refs/branch-heads/3945@{#869}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 1.1.19 Chromium: 79.0.3945.70 (Official Build) (64-bit)
Revision 65868db27916cebde51fc2465c9b34761e6383e2-refs/branch-heads/3945@{#869}
OS Windows 10 OS Version 1809 (Build 17763.864)

  • reproduced the original issue using 1.1.18 Chromium: 79.0.3945.56
  • went through and verified the original STR as per Welcome page slides are not centered #6846 (comment)
  • ensured that the brave://welcome page is aligned on initial launch
  • ensured that the brave://welcome page is aligned when navigating through the different pages
  • ensured that each page is correctly aligned when interacting with buttons (Import, Set Default etc..)
  • ensured alignment looks correct when navigating through each page using both Next & bullets
  • ensured that resizing the brave://welcome window doesn't cause any alignment issues
  • ensured that all the links are working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment