Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.73.x] Fix alignment on Welcome page content #3942

Closed
wants to merge 1 commit into from

Conversation

cezaraugusto
Copy link
Contributor

Content was not centered causing a bad UI. This commit fix that.

fix brave/brave-browser#6846

Sibling PR #3940

@cezaraugusto cezaraugusto added this to the 0.73.x - Dev milestone Nov 8, 2019
@cezaraugusto cezaraugusto requested a review from a team November 8, 2019 18:56
@cezaraugusto cezaraugusto self-assigned this Nov 8, 2019
@kjozwiak
Copy link
Member

Looks this never really started and eventually timed out. Restarting.

@kjozwiak
Copy link
Member

Restarting Linux due to the following error as per https://ci.brave.com/job/brave-browser-build-pr/job/ca-6846-73/1/execution/node/729/log/:

18:29:25  [33300:33300:1110/232925.402336:ERROR:ledger_impl.cc(103)] Failed to initialize wallet
18:30:33  [33253:33253:1110/233025.296282:ERROR:gcm_channel_status_request.cc(145)] GCM channel request failed.
18:30:48  [33253:33253:1110/233045.875872:ERROR:gcm_channel_status_request.cc(145)] GCM channel request failed.
18:31:27  undefined:17042
18:31:27  {"params":{"type":"SQLitePersistentCookieStore"},"phase":0,"source":{"id":4,"type":29}]}
18:31:27                                                                                        ^
18:31:27  
18:31:27  SyntaxError: Unexpected token ] in JSON at position 49826675
18:31:27      at JSON.parse (<anonymous>)
18:31:27      at start (/home/ubuntu/jenkins/workspace/rave-browser-build-pr_ca-6846-73/lib/start.js:144:23)
18:31:27      at Command.listener (/home/ubuntu/jenkins/workspace/rave-browser-build-pr_ca-6846-73/node_modules/commander/index.js:315:8)
18:31:27      at Command.emit (events.js:210:5)
18:31:27      at Command.parseArgs (/home/ubuntu/jenkins/workspace/rave-browser-build-pr_ca-6846-73/node_modules/commander/index.js:654:12)
18:31:27      at Command.parse (/home/ubuntu/jenkins/workspace/rave-browser-build-pr_ca-6846-73/node_modules/commander/index.js:474:21)
18:31:27      at Object.<anonymous> (/home/ubuntu/jenkins/workspace/rave-browser-build-pr_ca-6846-73/scripts/commands.js:158:4)
18:31:27      at Module._compile (internal/modules/cjs/loader.js:956:30)
18:31:27      at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
18:31:27      at Module.load (internal/modules/cjs/loader.js:812:32)
18:31:27  npm ERR! code ELIFECYCLE

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Nov 11, 2019
Content was not centered causing a bad UI. This commit fix that.

fix brave/brave-browser#6846
@kjozwiak
Copy link
Member

@cezaraugusto going to restart this on CI/skip-android, CI/skip-ios, CI/skip-macos, CI/skip-windows as they were skipped.

@kjozwiak kjozwiak added CI/skip-linux and removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Nov 12, 2019
@kjozwiak
Copy link
Member

Restarting Android due to the following issue as per https://ci.brave.com/job/brave-browser-build-pr/job/ca-6846-73/4/execution/node/466/log/:

07:27:00  FAILED: obj/third_party/icu/icuuc/ucol_swp.o 
07:27:00  /home/ubuntu/jenkins/workspace/rave-browser-build-pr_ca-6846-73/src/brave/script/redirect-cc.py ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/icu/icuuc/ucol_swp.o.d -DU_COMMON_IMPLEMENTATION -DU_ICUDATAENTRY_IN_COMMON -DBRAVE_CHROMIUM_BUILD -DOFFICIAL_BUILD -DNO_UNWIND_TABLES -D_GNU_SOURCE -DANDROID -DHAVE_SYS_UIO_H -DANDROID_NDK_VERSION_ROLL=r20_1 -DCR_CLANG_REVISION=\"371202-8455294f-1\" -D_LIBCPP_ABI_UNSTABLE -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_ENABLE_NODISCARD -DCR_LIBCXX_REVISION=361348 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DHAVE_DLOPEN=0 -DUCONFIG_ONLY_HTML_CONVERSION=1 -DUCONFIG_USE_WINDOWS_LCID_MAPPING_API=0 -DU_CHARSET_IS_UTF8=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -I../../brave/chromium_src -I../.. -Igen -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fprofile-sample-use=../../chrome/android/profiles/afdo.prof -fprofile-sample-accurate -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -flto=thin -fsplit-lto-unit -fcomplete-member-pointers -ffunction-sections -fno-short-enums --target=arm-linux-androideabi16 -DHAVE_PTHREAD_COND_TIMEDWAIT_MONOTONIC=1 -march=armv7-a -mfloat-abi=softfp -mtune=generic-armv7-a -Xclang -fdebug-compilation-dir -Xclang . -no-canonical-prefixes -mfpu=neon -mthumb -Oz -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -gdwarf-3 -g1 -fdebug-info-for-profiling -fvisibility=hidden -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Werror -Wall -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-ignored-pragma-optimize -Wno-implicit-int-float-conversion -Wno-xor-used-as-pow -Wno-c99-designator -Wno-reorder-init-list -Wno-final-dtor-non-final-class -Wno-unused-function -Wno-parentheses -Wno-unused-function -Wno-unused-variable -Wno-deprecated-declarations -std=c++14 -fno-exceptions -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../third_party/android_ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot -fvisibility-inlines-hidden -frtti -c ../../third_party/icu/source/common/ucol_swp.cpp -o obj/third_party/icu/icuuc/ucol_swp.o
07:27:00  Terminated
07:27:01  null
07:27:01  null
07:27:02  npm ERR! code ELIFECYCLE
07:27:02  npm ERR! errno 1
07:27:02  npm ERR! brave@0.73.63 build: `node ./scripts/commands.js build "Release" "--channel=nightly" "--official_build=true" "--target_os=android" "--target_arch=arm"`
07:27:02  npm ERR! Exit status 1
07:27:02  npm ERR! 
07:27:02  npm ERR! Failed at the brave@0.73.63 build script.
07:27:02  npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
07:27:02  
07:27:02  npm ERR! A complete log of this run can be found in:
07:27:02  npm ERR!     /home/ubuntu/.npm/_logs/2019-11-12T12_27_02_477Z-debug.log
07:27:03  script returned exit code 1

@kjozwiak kjozwiak added CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Nov 12, 2019
@kjozwiak
Copy link
Member

Waiting till #3940 is finally merged into master. Looks like there's a few other changes that need to happen.

@kjozwiak
Copy link
Member

@cezaraugusto going to close this PR until #3940 has been completed and merged. The current process is to make sure that the master issue is reviewed/merged before creating uplifts into other channels.

@kjozwiak kjozwiak closed this Nov 15, 2019
@kjozwiak kjozwiak deleted the ca-6846-73 branch November 15, 2019 23:36
@kjozwiak kjozwiak removed the request for review from a team November 15, 2019 23:37
@kjozwiak kjozwiak removed this from the 1.2.x - Dev milestone Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants