-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable widevine cdm component updater in linux #7081
Comments
We are not ready to use chrome's widevine cdm component updater in linux. We are using our own widevine updater for now. Our widevine updater should be integrated with widevine cdm component updater. Issue: brave/brave-browser#7081
We are not ready to use chrome's widevine cdm component updater in linux. We are using our own widevine updater for now. Our widevine updater should be integrated with widevine cdm component updater. Issue: brave/brave-browser#7081
We are not ready to use chrome's widevine cdm component updater in linux. We are using our own widevine updater for now. Our widevine updater should be integrated with widevine cdm component updater. Issue: brave/brave-browser#7081
We are not ready to use chrome's widevine cdm component updater in linux. We are using our own widevine updater for now. Our widevine updater should be integrated with widevine cdm component updater. Issue: brave/brave-browser#7081
@simonhong Is this one still needed? or a dupe? |
@rebron This issue is still valid. |
I want to mention my PR brave/brave-core#7164 here. Maybe it is related. If I read Chromium's code correctly, then components are installed by registering them with version 0.0.0.0 and then waiting for an automatic update to install the correct version. Automatic updates are currently broken in Brave for those components that are not hosted on Brave's own component update server. Brave seems to implicitly rely on this to prevent unwanted components from being installed: By not hosting them, the automatic update check fails and the component isn't installed. The Widevine plugin is an exception to the above. It is not hosted on Brave's server for licensing reasons. However, to still be installed, it has a workaround in brave-core to perform an immediate on-demand update check. Unlike automatic updates, on-demand update checks do work and so Widevine is installed:
@simonhong My PR would fix the broken automatic component updates. Does this have any implications on your work on this issue? In particular, will your code still work once automatic component updates work again? More info about exactly why and how automatic component updates are currently broken can be found at #10464 (comment). |
@mherrmann Thanks for sharing. I didn't know why we do explicit on-demend update. |
Okay, great! :) |
Verification passed on
Verified test plan from brave/brave-core#7228 Test with old profile(widevine enabled) |
With C79, linux can component updater for widevine cdm.
Currently, we use our own widevine updater. So, need to integrate both.
In linux, brave://components should have widevine component entry.
The text was updated successfully, but these errors were encountered: