Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use widevine component on linux #12847

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Use widevine component on linux #12847

merged 1 commit into from
Dec 4, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Nov 23, 2020 •
edited
Loading

We don't need to set widevine version anymore.
We will get widevine as a component.

Resolves #7081

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong simonhong self-assigned this Nov 23, 2020
@simonhong simonhong marked this pull request as ready for review November 23, 2020 11:51
@simonhong simonhong changed the title Use widevine component WIP: Use widevine component Nov 23, 2020
@simonhong simonhong force-pushed the widevine_component_linux branch from 96089b2 to a765c9c Compare November 25, 2020 04:56
@simonhong simonhong changed the title WIP: Use widevine component Use widevine component Nov 25, 2020
@simonhong simonhong changed the title Use widevine component Use widevine component on linux Nov 27, 2020
@simonhong simonhong force-pushed the widevine_component_linux branch 3 times, most recently from 0b6e08b to 0669ac8 Compare December 3, 2020 02:14
@simonhong
Use widevine component
89a6705 
We don't need to set widevine version anymore.
We will get widevine as a component.
@simonhong simonhong force-pushed the widevine_component_linux branch from 0669ac8 to 89a6705 Compare December 3, 2020 11:47
@simonhong simonhong merged commit 8ef8835 into master Dec 4, 2020
@simonhong simonhong deleted the widevine_component_linux branch December 4, 2020 08:42
@simonhong simonhong added this to the 1.20.x - Nightly milestone Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iefremov iefremov iefremov approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
1.20.x - Release
Development

Successfully merging this pull request may close these issues.

Enable widevine cdm component updater in linux
2 participants
@simonhong @iefremov