brave://settings/clearBrowserData doesn't automatically shows up requested dialog

[saahriktu]

Description

The behavior of the history cleanup dialog has changed (noticed in GNU/Linux).

In the versions newer than 1.8.30 brave://settings/clearBrowserData just shows brave://settings/ with some difference: requested cleanup dialog shows up only after clicking on the "Advanced Settings" button (which has nothing to do with history cleaning) at the end of the page.

Test plan

See #8870 (comment)

[kjozwiak]

• 1.5.115 CR: 80.0.3987.149 (Official Build) (64-bit) - Can't reproduce
• 1.7.73 CR: 80.0.3987.149 (Official Build) dev - Can't reproduce
• 1.8.32 CR: 81.0.4044.69 (Official Build) nightly - Reproduced

Looks like this is only affecting Nightly and not the other channels. Checked on macOS 10.15.3 x64 Catalina. @mkarolin checked Windows and confirmed the above as well.

STR for QA:

Case #1

• launch brave and open brave://settings/clearBrowserData
• you'll notice that the Clear browsing data modal isn't being displayed

Case #2

• launch brave and press command + shift + delete
• you'll notice that brave://settings is opened but that Clear browsing data modal isn't being displayed

[bsclifton]

Great find with 1.8.30, @saahriktu! 😄 1.8.31 was the first version of Nightly where we landed Chromium 81, which helps narrow down where the problem is 👍 We'll look into and find out what happened

[bsclifton]

@mkarolin has found the following:

1. Navigate to brave://settings/clearBrowserData
2. Nothing happens (clear modal should come up)
3. Click advanced on the side menu (left)
4. Modal all of the sudden pops up

I suspect it's related to brave/brave-core@9d2f803#diff-166e28418b661667403b64249ce36c3a and how Privacy was moved under Advanced

[btlechowski]

Verification passed on

Brave	1.8.72 Chromium: 81.0.4044.92 (Official Build) dev (64-bit)
Revision	e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS	Ubuntu 18.04 LTS

Verified test plan from #8870 (comment)
Verified opening the modal though brave://settings/clearBrowserData and CTRL + SHIFT + DEL

Verification passed on

Brave	1.8.77 Chromium: 81.0.4044.92 (Official Build) dev (64-bit)
Revision	e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from brave://settings/clearBrowserData doesn't automatically shows up requested dialog #8870 (comment)
• Verified opening the modal though brave://settings/clearBrowserData and CTRL + SHIFT + DEL
  

---

Verified passed with

Brave	1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision	e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS	macOS Version 10.14.6 (Build 18G3020)

• Verified test plan from brave://settings/clearBrowserData doesn't automatically shows up requested dialog #8870 (comment)
• Verified the modal is also opened via:
  • hamburger menu > More Tools > Clear browsing data
  • macOS File menu > Brave > Clear browsing data

Verification PASSED on macOS 10.15.3 x64 Catalina using the following build:

Brave | 1.7.98 Chromium: 81.0.4044.113 (Official Build) (64-bit)
-- | --
Revision | e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS | macOS Version 10.15.3 (Build 19D76)

• Verified the STR/Test Plan outlined via brave://settings/clearBrowserData doesn't automatically shows up requested dialog #8870 (comment)
• Ensured that the brave://settings/clearBrowserData modal is also opened via
  • Hamburger menu -> More Tools -> Clear browsing data
  • macOS File menu -> Brave -> Clear browsing data