Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Clear Browsing Data dialog not showing. #5074

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#8870

Adjusted CLEAR_BROWSING_DATA route to have Advanced as a parent since we
moved Privacy page from BASIC to ADVANCED section.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Fixes brave/brave-browser#8870

Adjusted CLEAR_BROWSING_DATA route to have Advanced as a parent since we
moved Privacy page from BASIC to ADVANCED section.
@mkarolin mkarolin added this to the 1.8.x - Nightly milestone Mar 26, 2020
@mkarolin mkarolin self-assigned this Mar 26, 2020
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 😄👍

@mkarolin mkarolin added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Mar 26, 2020
@mkarolin
Copy link
Collaborator Author

CI failed on Windows due to Jenkins instance going away. Restarting on Windows only.

@mkarolin
Copy link
Collaborator Author

CI passed.

@mkarolin mkarolin merged commit 0289a64 into master Mar 27, 2020
@mkarolin mkarolin deleted the maxk-issue-8870 branch March 27, 2020 01:34
mkarolin added a commit that referenced this pull request Apr 8, 2020
Fixes Clear Browsing Data dialog not showing.
bsclifton pushed a commit that referenced this pull request Apr 13, 2020
Fixes Clear Browsing Data dialog not showing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brave://settings/clearBrowserData doesn't automatically shows up requested dialog
2 participants