Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Toggling 3p cookie settings breaks Twitter #9489

Closed
jumde opened this issue Apr 27, 2020 · 2 comments · Fixed by brave/brave-core#5390
Closed

[Android] Toggling 3p cookie settings breaks Twitter #9489

jumde opened this issue Apr 27, 2020 · 2 comments · Fixed by brave/brave-core#5390
Labels
feature/shields/cookies Cookie controls implemented as part of Shields. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Yes release-notes/include
Milestone
Android 1.8.x Rel...

Comments

@jumde
Copy link
Contributor

jumde commented Apr 27, 2020

Description

Toggling 3p settings from on-off-on breaks twitter. This is likely because of shield settings not applying the 3p cookie exceptions correctly.

Steps to reproduce

  1. Navigate to twitter.com/pjumde
  2. Toggle 3p cookie settings
  3. Tweets cannot be loaded.

Actual result

Tweets are not visible

Expected result

Tweets should be visible

Issue reproduces how often

Easily
@jumde jumde added the OS/Android Fixes related to Android browser functionality label Apr 27, 2020
@kjozwiak
Copy link
Member

Some more context via brave/brave-core#5318 (comment), brave/brave-core#5318 (comment) and brave/brave-core#5318 (comment) regarding the above not working on Android.

@bridiver bridiver mentioned this issue Apr 27, 2020
Merged
32 tasks
@srirambv srirambv added feature/shields/cookies Cookie controls implemented as part of Shields. QA/Yes labels Apr 28, 2020
bridiver added a commit to brave/brave-core that referenced this issue Apr 28, 2020
@bridiver
use domain registry to get the correct parent domain for 3rd-party co…
f7449a0 
…okies

fix brave/brave-browser#9489
This was referenced Apr 28, 2020
Merged
Merged
@kjozwiak kjozwiak added this to the Android 1.8.x Release milestone May 4, 2020
This was referenced May 6, 2020
Closed
Closed
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 6, 2020 •
edited by LaurenWags
Loading

Verification passed on Samsung Galaxy J5 version 5.1.1 running BraveModernarm.apk 1.8.93

Verification passed on BraveModernarm v1.8.93 on Samsung Galaxy Tab S5e (Android 9.0)

Verification passed on Asus Zenfone (x86) with Android 6 running BraveModernx86.apk 1.8.93

@kjozwiak kjozwiak mentioned this issue May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/shields/cookies Cookie controls implemented as part of Shields. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Yes release-notes/include
Projects
None yet
Milestone
Android 1.8.x Release
Development

Successfully merging a pull request may close this issue.

3rd party cookie registry domains brave/brave-core
6 participants
@jumde @kjozwiak @srirambv @LaurenWags @btlechowski @GeetaSarvadnya