Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing a theme adds a blob on new tab button #983

Closed
srirambv opened this issue Sep 6, 2018 · 4 comments · Fixed by brave/brave-core#430
Closed

Installing a theme adds a blob on new tab button #983

srirambv opened this issue Sep 6, 2018 · 4 comments · Fixed by brave/brave-core#430

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 6, 2018

Description

Installing a theme adds a blob on new tab button

Steps to Reproduce

  1. Upgrade to 0.55.1
  2. Open Chrome store and add a theme
  3. See new tab button get a beauty spot on top

Actual result:

theme

Expected result:

Should not get a beauty spot when a theme is installed

Reproduces how often:

100%

Brave version (about:brave info)

Brave 0.55.1 Chromium: 70.0.3528.4 (Official Build) dev (64-bit)
Revision 1911f781145b803e04f2d0b5b1a0146ae69fcbdc-refs/branch-heads/3528@{#9}
OS Windows / Linux

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @LaurenWags @kjozwiak to verify on mac for same behaviour

@srirambv srirambv added this to the 1.x Backlog milestone Sep 6, 2018
@kjozwiak
Copy link
Member

Talked to @srirambv about this earlier today. It seems to be happening on my Win 7 & Win 8 VM's that are using the default themes. The VM's that I created are basically using the same theme that was enabled when the OS was installed. I didn't change any settings/themes etc.. The VM's are updated, but are using all the default settings and not themes were installed/selected. Examples:

  • Windows 7:

screen shot 2018-09-10 at 1 47 09 am

screen shot 2018-09-10 at 1 48 10 am

  • Windows 8:

screen shot 2018-09-10 at 1 50 09 am

screen shot 2018-09-10 at 1 50 33 am

@GeetaSarvadnya
Copy link

Verified the issue on Windows 10. Issue is working fine on Default theme as well as on added new theme, now we are not able to see dot on + tab on version1.55.5
@kjozwiak @srirambv Issue needs to be verified on Win 7 and Win 8 with default theme and new theme.

@btlechowski
Copy link

Verification passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

image

@kjozwiak kjozwiak removed the QA/Yes label Sep 21, 2018
@kjozwiak
Copy link
Member

Looks like it's also resolved on my VM's where I used to see the beauty mark while using the default themes of each OS as mentioned in #983 (comment). Used the following build for verification:

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}

Windows 10 x64 VM using default theme - PASSED

screen shot 2018-09-24 at 5 07 23 pm

Windows 8.1 x64 VM using default theme - PASSED

screen shot 2018-09-24 at 5 10 51 pm

Windows 7 x64 VM using default theme - PASSED

screen shot 2018-09-24 at 5 15 53 pm

@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants