-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix newtab button isn't clickable #430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments left. Looking forward to this being fixed :)
With chromium's recent change, this button's border path rect is calculated by using corder radius with layout value of EMPHASIS_MAXIMUM. However, we changed that value to 4. Because of this, path rect is calculated much smaller than buttons size. So, most hittest was failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for the fix! I knew it was an issue with themes, but guessing it was made worse with C70 to affect the hit test.
Fix newtab button isn't clickable
0.55.x 04a458f |
Updated both issues milestones. One wasn't set and the other was set wrongly to 1.0. |
With chromium's recent change, this button's border path rect is
calculated by using corder radius with layout value of EMPHASIS_MAXIMUM.
However, we changed that value to 4. Because of this, path rect is
calculated much smaller than buttons size.
So, most hittest was failed.
This also fixes the problem that a blob is visible on newtab button when theme is installed.
The blob's rect is also same as above small clickable rect.
W/o theme, button background and tab strip background color is same.
So, we didn't see that blob but it was there.
Close brave/brave-browser#1092
Close brave/brave-browser#983
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Check new tab button work with mouse click
Reviewer Checklist: