-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort auto contribute table #988
Comments
This has been fixed with: brave/brave-core#441 |
This should be done on DB level and not in JS level. So when you fetch publishers for auto contribute table you should specify order in SQL query using this logic here https://github.com/brave/brave-core/blob/master/components/brave_rewards/browser/publisher_info_database.cc#L366 |
@NejcZdovc will we never have any other type of sorting on this table? It will always be DESC by percentage? If we have plans in the future to provide more sorting options for this, we should receive the initial publisher set (perhaps already in DESC order) and let the client-side handle the sorting of data for speed. |
@ryanml we will probably have some sorting, but I don't see this in a near future. When we will have this I suggest that we do generic sorting in table component and pass in default sort as part of header prop for table. This way we just do in once and use it everywhere. example of header prop
|
Verified passed with
Using test plan from brave/brave-core#487 Verification passed on
Verification Passed on
|
We need to sort table in DESC order based on %.
The text was updated successfully, but these errors were encountered: