This repository has been archived by the owner on May 13, 2024. It is now read-only.
Adding sort prop to ModalContribute, TableContribute #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petemill
approved these changes
Sep 12, 2018
There was a problem hiding this comment.
Looks good. Just a couple nits:
- Is the attention for sort to take any other option, such as different columns? If not, the current implementation is pretty binary, so perhaps a simplification would be better and not have to pass through
Sorttype or do string comparison for the prop - e.g.sortByAttentionDescending: bool = true
|
@petemill my thought was that eventually we may want to have other columns as the pivot for sort (like name, verified, etc) so I left the type as a string. You are right that at this time it's pretty binary, I can update it to a bool flag. Thanks! |
|
@petemill changes made |
cezaraugusto
approved these changes
Sep 12, 2018
|
@ryanml can we revert this one as we don't want to do sorting for auto contribute on JS level but on DB level. More info here brave/brave-browser#988 (comment) |
ryanml
added a commit
to ryanml/brave-ui
that referenced
this pull request
Sep 17, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #146