Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove string replacements as they are done in Python now #10560

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jul 3, 2020

Resolves #10186

Sister PR: brave/brave-core#5795

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit a9908c3 into master Jul 6, 2020
@bbondy bbondy deleted the l10n-less branch July 6, 2020 16:25
mkarolin pushed a commit that referenced this pull request Jul 6, 2020
Remove string replacements as they are done in Python now
mkarolin pushed a commit that referenced this pull request Jul 7, 2020
Remove string replacements as they are done in Python now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce amount of strings we need to pull/push with Transifex
2 participants