Upgrade from Chromium 83 to Chromium 84 #5679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarolin
commented
May 27, 2020
patches/chrome-android-java-src-org-chromium-chrome-browser-ntp-NewTabPageView.java.patch
Show resolved
Hide resolved
mkarolin
force-pushed
the
cr84
branch
2 times, most recently
from
2914248 to
92687fa
Compare
mkarolin
force-pushed
the
cr84
branch
2 times, most recently
from
204a4aa to
fd4dbfa
Compare
samartnik
force-pushed
the
cr84
branch
2 times, most recently
from
532e4e4 to
1144b48
Compare
mkarolin
commented
Jun 12, 2020
mkarolin
commented
Jun 15, 2020
mkarolin
commented
Jun 15, 2020
mkarolin
force-pushed
the
cr84
branch
2 times, most recently
from
d22f16d to
f960e7a
Compare
29 tasks
|
@jumde updated BraveUpdateClientConfig here e1681f618360809c6c696eee683ed52861f332f5 to inherit from ChromeUpdateClientConfig instead of copying the entire ChromeUpdateClientConfig functionality. Any reason not to do this? |
mkarolin
force-pushed
the
cr84
branch
2 times, most recently
from
ad24949 to
1a40478
Compare
NejcZdovc
approved these changes
Jun 25, 2020
mkarolin
force-pushed
the
cr84
branch
2 times, most recently
from
cbd48e6 to
c3ee055
Compare
brave_clear_browsing_data_dialog_behavior is included as straight .js, not generated
Items in these sections are contained in brave's get started section. These sections were re-introduced with chromium 84
The version of clang included with Xcode (as high as XCode 11.4.1) doesn't recognize #pragma clang max_tokens_here. The pragma was added to clang here: https://reviews.llvm.org/rG739b410f1ff51d507830774320c2db3a80d8610d The Chromium change that started using it: https://chromium.googlesource.com/chromium/src/+/b3e433a31194beb54e70acceba9401f47c74fc7d commit b3e433a31194beb54e70acceba9401f47c74fc7d Author: Hans Wennborg <hans@chromium.org> Date: Tue Apr 21 11:21:40 2020 +0000 [base] Reduce the size of base/debug/alias.h significantly. This is a very widely included header, with ca 11,000 transitive includes for the 'chrome' target in Linux debug builds. Despite providing very basic functionality, its size was a whopping 480,000 tokens after pre-processing. This change brings the size down to 130 tokens on Linux. Bug: 242216
Addresses code review suggestions Chromium change: https://chromium.googlesource.com/chromium/src/+/204335845d2b7292bb99cb880203b7d132ddfa72 commit 204335845d2b7292bb99cb880203b7d132ddfa72 Author: Colin Blundell <blundell@chromium.org> Date: Wed Apr 15 08:52:29 2020 +0000 [Android] Componentize InterceptNavigationDelegateImpl After preceding CLs this class has no remaining //chrome dependencies other than resources, which this CL componentizes along with the class itself. As this implementation of InterceptNavigationDelegate is specific to the overall intent launching logic in //components/external_intents, this CL componentizes it into that component. Componentizing this class will enable it to be reused in WebLayer. Bug: 1031465
As per code review suggestions
As per code review suggestions
Manually moved to BraveNewTabPageLayout as NewTabPageView was removed
|
CI: only errors are in |
mkarolin
added a commit
that referenced
this pull request
Jul 2, 2020
Upgrade from Chromium 83 to Chromium 84
32 tasks
mkarolin
added a commit
that referenced
this pull request
Jul 7, 2020
Upgrade from Chromium 83 to Chromium 84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#10364
Fixes brave/brave-browser#8365
Related PR: brave/brave-browser#10363
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.