-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneccessary resource compilation from android #5951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petemill
requested review from
bridiver,
fmarier,
darkdh,
SergeyZhukovsky and
samartnik
June 25, 2020 22:31
samartnik
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
5 tasks
error in android build
|
petemill
force-pushed
the
android-no-compile-settings
branch
from
June 30, 2020 23:14
c953ad8
to
cd9848f
Compare
Pushed a fix, waiting for build |
android passed everything, just macOS test failure 🤷 |
- Settings - NTP - Welcome
petemill
force-pushed
the
android-no-compile-settings
branch
from
July 1, 2020 18:54
cd9848f
to
574fe4d
Compare
Rebased on master, looks like master fixes those tests |
uncritical CI failure (unstable status), 1 linux test error:
All ✔️ on android. |
32 tasks
32 tasks
mkarolin
pushed a commit
that referenced
this pull request
Jul 7, 2020
Remove unneccessary resource compilation from android
Uplifted to 1.11.x with #5996 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#10479