Skip to content

Commit

Permalink
Merge pull request #5679 from brave/cr84
Browse files Browse the repository at this point in the history
Upgrade from Chromium 83 to Chromium 84
  • Loading branch information
mkarolin committed Jul 7, 2020
1 parent 8af37e0 commit 0f7207b
Show file tree
Hide file tree
Showing 695 changed files with 7,072 additions and 6,668 deletions.
6 changes: 4 additions & 2 deletions android/brave_java_resources.gni
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,6 @@ brave_java_resources = [
"java/res/layout/fragment_rate_dialog.xml",
"java/res/layout/brave_ads_new_user_dialog_layout.xml",
"java/res/layout/brave_shields_text_item.xml",
"java/res/layout/new_tab_page_view.xml",
"java/res/layout/fragment_brave_ads_onboarding.xml",
"java/res/layout/brave_rewards_reset_tab_content.xml",
"java/res/layout/brave_bookmark_toolbar.xml",
Expand Down Expand Up @@ -716,7 +715,10 @@ brave_java_resources = [
"java/res/xml/brave_rewards_preferences.xml",
"java/res/xml/closing_all_tabs_closes_brave_preference.xml",
"java/res/xml/clear_browsing_data_preferences_tab.xml",
"java/res/xml/brave_site_settings_preferences.xml",
"java/res/xml/brave_privacy_preferences.xml",
"java/res/xml/appearance_preferences.xml",
]

brave_components_browser_ui_site_settings_android_java_resources = [
"//brave/components/browser_ui/site_settings/android/java/res/xml/brave_site_settings_preferences.xml",
]
14 changes: 12 additions & 2 deletions android/brave_java_sources.gni
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import("//brave/browser/brave_ads/android/java_sources.gni")
import("//brave/components/brave_ads/browser/buildflags/buildflags.gni")
import("//brave/components/brave_rewards/browser/android/java_sources.gni")
import("//brave/components/brave_rewards/browser/buildflags/buildflags.gni")
import("//components/feed/features.gni")

brave_java_sources = [
"../../brave/android/java/org/chromium/chrome/browser/BraveActivity.java",
Expand Down Expand Up @@ -48,8 +49,8 @@ brave_java_sources = [
"../../brave/android/java/org/chromium/chrome/browser/BraveUphold.java",
"../../brave/android/java/org/chromium/chrome/browser/notifications/channels/BraveChannelDefinitions.java",
"../../brave/android/java/org/chromium/chrome/browser/ntp/BraveDuckDuckGoOfferView.java",
"../../brave/android/java/org/chromium/chrome/browser/ntp/BraveNewTabPage.java",
"../../brave/android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java",
"../../brave/android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageView.java",
"../../brave/android/java/org/chromium/chrome/browser/ntp/IncognitoNewTabPageView.java",
"../../brave/android/java/org/chromium/chrome/browser/ntp_background_images/model/NTPImage.java",
"../../brave/android/java/org/chromium/chrome/browser/ntp_background_images/model/BackgroundImage.java",
Expand Down Expand Up @@ -110,7 +111,6 @@ brave_java_sources = [
"../../brave/android/java/org/chromium/chrome/browser/settings/SearchEngineTabModelSelectorObserver.java",
"../../brave/android/java/org/chromium/chrome/browser/settings/themes/BraveRadioButtonGroupCustomHomepageThemePreference.java",
"../../brave/android/java/org/chromium/chrome/browser/signin/BraveSigninManager.java",
"../../brave/android/java/org/chromium/chrome/browser/site_settings/BraveSiteSettingsPreferencesBase.java",
"../../brave/android/java/org/chromium/chrome/browser/site_settings/DesktopModePreferences.java",
"../../brave/android/java/org/chromium/chrome/browser/site_settings/PlayYTVideoInBrowserPreferences.java",
"../../brave/android/java/org/chromium/chrome/browser/sync/BraveSyncService.java",
Expand Down Expand Up @@ -150,3 +150,13 @@ if (brave_rewards_enabled) {
if (brave_ads_enabled) {
brave_java_sources += brave_ads_java_sources
}

if (enable_feed_in_chrome) {
brave_java_sources += [
"//brave/android/feed/core/java/src/org/chromium/chrome/browser/feed/BraveFeedSurfaceCoordinator.java",
]
}

brave_components_browser_ui_site_settings_android_java = [
"//brave/components/browser_ui/site_settings/android/java/src/org/chromium/components/browser_ui/site_settings/BraveSiteSettingsPreferencesBase.java",
]
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
/* Copyright (c) 2020 The Brave Authors. All rights reserved.
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */

package org.chromium.chrome.browser.feed;

import android.app.Activity;
import android.view.View;
import android.widget.FrameLayout;
import android.widget.ScrollView;

import androidx.annotation.Nullable;

import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.supplier.Supplier;
import org.chromium.chrome.browser.feed.library.api.host.action.ActionApi;
import org.chromium.chrome.browser.feed.shared.FeedSurfaceDelegate;
import org.chromium.chrome.browser.native_page.NativePageNavigationDelegate;
import org.chromium.chrome.browser.ntp.SnapScrollHelper;
import org.chromium.chrome.browser.ntp.snippets.SectionHeaderView;
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.TabModelSelector;
import org.chromium.chrome.browser.ui.messages.snackbar.SnackbarManager;
import org.chromium.chrome.feed.R;
import org.chromium.ui.UiUtils;

public class BraveFeedSurfaceCoordinator extends FeedSurfaceCoordinator {
private Activity mActivity;
private ScrollView mScrollViewForPolicy;
private View mNtpHeader;
private FrameLayout mRootView;

public BraveFeedSurfaceCoordinator(Activity activity, SnackbarManager snackbarManager,
TabModelSelector tabModelSelector, Supplier<Tab> tabProvider,
@Nullable SnapScrollHelper snapScrollHelper, @Nullable View ntpHeader,
@Nullable SectionHeaderView sectionHeaderView, ActionApi actionApi,
boolean showDarkBackground, FeedSurfaceDelegate delegate,
@Nullable NativePageNavigationDelegate pageNavigationDelegate, Profile profile) {
super(activity, snackbarManager, tabModelSelector, tabProvider, snapScrollHelper, ntpHeader,
sectionHeaderView, actionApi, showDarkBackground, delegate, pageNavigationDelegate,
profile);
}

@Override
void createScrollViewForPolicy() {
super.createScrollViewForPolicy();

// Remove previous view to recreate it a way we need for our NTP.
UiUtils.removeViewFromParent(mScrollViewForPolicy);
// Here we need to get rid of resizer and call setFillViewport.
mScrollViewForPolicy = new ScrollView(mActivity);
mScrollViewForPolicy.setBackgroundColor(
ApiCompatibilityUtils.getColor(mActivity.getResources(), R.color.default_bg_color));
mScrollViewForPolicy.setVerticalScrollBarEnabled(false);

// Make scroll view focusable so that it is the next focusable view when the url bar clears
// focus.
mScrollViewForPolicy.setFocusable(true);
mScrollViewForPolicy.setFocusableInTouchMode(true);
mScrollViewForPolicy.setContentDescription(
mScrollViewForPolicy.getResources().getString(R.string.accessibility_new_tab_page));

if (mNtpHeader != null) {
UiUtils.removeViewFromParent(mNtpHeader);
mScrollViewForPolicy.addView(mNtpHeader);
}
mRootView.addView(mScrollViewForPolicy);
mScrollViewForPolicy.setFillViewport(true);
mScrollViewForPolicy.requestFocus();
}
}
18 changes: 18 additions & 0 deletions android/java/apk_for_test.flags
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,21 @@
-keep class org.chromium.chrome.browser.homepage.HomepageManager {
*** shouldCloseAppWithZeroTabs(...);
}

-keep class org.chromium.chrome.browser.ntp.NewTabPageLayout {
*** insertSiteSectionView(...);
*** getMaxRowsForMostVisitedTiles(...);
*** mSiteSectionView;
}

-keep class org.chromium.chrome.browser.feed.FeedSurfaceCoordinator {
*** mActivity;
*** mScrollViewForPolicy;
*** mNtpHeader;
*** mRootView;
}

-keep class org.chromium.chrome.browser.ntp.NewTabPage {
*** mNewTabPageLayout;
*** mFeedSurfaceProvider;
}
31 changes: 13 additions & 18 deletions android/java/org/chromium/chrome/browser/BraveActivity.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,18 @@
package org.chromium.chrome.browser;

import android.app.Activity;
import android.app.AlertDialog;
import android.app.NotificationChannel;
import android.app.NotificationManager;
import android.content.Context;
import android.content.Intent;
import android.content.SharedPreferences;
import android.content.pm.PackageManager;
import android.content.pm.ResolveInfo;
import android.content.SharedPreferences;
import android.net.Uri;
import android.os.Build;
import android.os.Bundle;
import android.provider.Settings;
import android.support.v7.app.AlertDialog;
import android.text.TextUtils;
import android.view.Gravity;
import android.view.LayoutInflater;
Expand All @@ -44,26 +44,25 @@
import org.chromium.chrome.browser.preferences.BravePreferenceKeys;
import org.chromium.chrome.browser.preferences.Pref;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
import org.chromium.chrome.browser.rate.RateDialogFragment;
import org.chromium.chrome.browser.rate.RateUtils;
import org.chromium.chrome.browser.settings.BraveRewardsPreferences;
import org.chromium.chrome.browser.settings.BraveSearchEngineUtils;
import org.chromium.chrome.browser.share.ShareDelegate;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tab.TabImpl;
import org.chromium.chrome.browser.tab.TabLaunchType;
import org.chromium.chrome.browser.tab.TabSelectionType;
import org.chromium.chrome.browser.tabmodel.TabModel;
import org.chromium.chrome.browser.tabmodel.TabModelUtils;
import org.chromium.chrome.browser.tab.TabSelectionType;
import org.chromium.chrome.browser.toolbar.top.BraveToolbarLayout;
import org.chromium.chrome.browser.util.BraveDbUtil;
import org.chromium.chrome.browser.util.BraveReferrer;
import org.chromium.components.embedder_support.util.UrlConstants;
import org.chromium.chrome.browser.preferences.BravePreferenceKeys;
import org.chromium.components.bookmarks.BookmarkId;
import org.chromium.components.bookmarks.BookmarkType;
import org.chromium.components.embedder_support.util.UrlConstants;
import org.chromium.ui.widget.Toast;
import org.chromium.chrome.browser.rate.RateDialogFragment;
import org.chromium.chrome.browser.rate.RateUtils;
import org.chromium.chrome.browser.preferences.SharedPreferencesManager;

import java.util.Calendar;

Expand Down Expand Up @@ -93,21 +92,17 @@ public abstract class BraveActivity<C extends ChromeActivityComponent> extends C
// Sync worker
public BraveSyncWorker mBraveSyncWorker;

public BraveActivity() {
// Disable key checker to avoid asserts on Brave keys in debug
SharedPreferencesManager.getInstance().disableKeyCheckerForTesting();
}

@Override
public void onResumeWithNative() {
super.onResumeWithNative();
nativeRestartStatsUpdater();
}

@Override
public void onStartWithNative() {
super.onStartWithNative();

// Disable NTP suggestions
PrefServiceBridge.getInstance().setBoolean(Pref.NTP_ARTICLES_SECTION_ENABLED, false);
PrefServiceBridge.getInstance().setBoolean(Pref.NTP_ARTICLES_LIST_VISIBLE, false);
}

@Override
public boolean onMenuOrKeyboardAction(int id, boolean fromMenu) {
final TabImpl currentTab = (TabImpl) getActivityTab();
Expand Down Expand Up @@ -369,7 +364,7 @@ public void openRewardsPanel() {

public Tab selectExistingTab(String url) {
Tab tab = getActivityTab();
if (tab != null && tab.getUrl().equals(url)) {
if (tab != null && tab.getUrlString().equals(url)) {
return tab;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@

package org.chromium.chrome.browser;

import android.app.AlertDialog;
import android.content.Context;
import android.content.DialogInterface;
import android.support.v7.app.AlertDialog;

import org.chromium.chrome.R;
import org.chromium.base.annotations.JNINamespace;
import org.chromium.base.annotations.NativeMethods;
import org.chromium.chrome.R;

@JNINamespace("chrome::android")
public class BraveRelaunchUtils {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@
import android.view.View;

import org.chromium.base.annotations.CalledByNative;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.BraveActivity;
import org.chromium.chrome.browser.ChromeTabbedActivity;
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.ui.favicon.IconType;
import org.chromium.chrome.browser.ui.favicon.LargeIconBridge;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tab.TabImpl;
import org.chromium.chrome.browser.ui.favicon.RoundedIconGenerator;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ui.favicon.IconType;
import org.chromium.chrome.browser.ui.favicon.LargeIconBridge;
import org.chromium.components.browser_ui.widget.RoundedIconGenerator;
import org.chromium.url.GURL;

import java.math.BigDecimal;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,22 @@

package org.chromium.chrome.browser;

import android.os.Bundle;
import android.support.v7.app.AppCompatActivity;
import android.view.View;
import android.content.Intent;
import android.support.v7.app.ActionBar;
import android.support.v7.widget.Toolbar;
import android.os.Bundle;
import android.view.MenuItem;
import android.view.View;
import android.widget.Button;
import android.widget.TextView;

import androidx.appcompat.app.ActionBar;
import androidx.appcompat.app.AppCompatActivity;
import androidx.appcompat.widget.Toolbar;

import org.chromium.chrome.R;
import org.chromium.chrome.browser.BraveActivity;
import org.chromium.chrome.browser.BraveRewardsBalance;
import org.chromium.chrome.browser.BraveRewardsExternalWallet;
import org.chromium.chrome.browser.BraveRewardsNativeWorker;
import org.chromium.chrome.browser.BraveRewardsBalance;
import org.chromium.chrome.R;


public class BraveRewardsUserWalletActivity extends AppCompatActivity {

Expand Down
12 changes: 7 additions & 5 deletions android/java/org/chromium/chrome/browser/BraveUphold.java
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,26 @@
*/
package org.chromium.chrome.browser;

import android.app.AlertDialog;
import android.content.Context;
import android.content.DialogInterface;
import android.net.Uri;
import android.text.TextUtils;
import android.support.v7.app.AlertDialog;
import java.util.Locale;

import org.json.JSONException;
import org.json.JSONObject;

import org.chromium.base.ContextUtils;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.BraveActivity;
import org.chromium.chrome.browser.BraveRewardsBalance;
import org.chromium.chrome.browser.BraveRewardsHelper;
import org.chromium.chrome.browser.BraveRewardsNativeWorker;
import org.chromium.chrome.browser.BraveRewardsObserver;
import org.chromium.chrome.browser.externalnav.BraveExternalNavigationHandler;
import org.chromium.components.external_intents.ExternalNavigationParams;
import org.chromium.chrome.R;
import org.json.JSONException;
import org.json.JSONObject;

import java.util.Locale;

//used from org.chromium.chrome.browser.externalnav
public class BraveUphold implements BraveRewardsObserver {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,27 @@

import android.content.Context;
import android.support.annotation.Nullable;
import android.support.v7.content.res.AppCompatResources;
import android.view.Menu;
import android.view.MenuItem;
import android.view.View;
import android.widget.ImageButton;

import androidx.appcompat.content.res.AppCompatResources;

import org.chromium.base.supplier.ObservableSupplier;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ActivityTabProvider;
import org.chromium.chrome.browser.BraveFeatureList;
import org.chromium.chrome.browser.flags.ChromeFeatureList;
import org.chromium.chrome.browser.bookmarks.BookmarkBridge;
import org.chromium.chrome.browser.compositor.layouts.OverviewModeBehavior;
import org.chromium.chrome.browser.flags.ChromeFeatureList;
import org.chromium.chrome.browser.multiwindow.MultiWindowModeStateDispatcher;
import org.chromium.chrome.browser.notifications.BraveSetDefaultBrowserNotificationService;
import org.chromium.chrome.browser.preferences.BravePrefServiceBridge;
import org.chromium.chrome.browser.tabbed_mode.TabbedAppMenuPropertiesDelegate;
import org.chromium.chrome.browser.tabmodel.TabModelSelector;
import org.chromium.chrome.browser.toolbar.bottom.BottomToolbarConfiguration;
import org.chromium.chrome.browser.toolbar.ToolbarManager;
import org.chromium.chrome.browser.toolbar.bottom.BottomToolbarConfiguration;
import org.chromium.chrome.browser.ui.appmenu.AppMenuDelegate;
import org.chromium.chrome.browser.ui.appmenu.AppMenuHandler;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import android.os.Bundle;

import org.chromium.chrome.browser.BraveHelper;
import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
import org.chromium.chrome.browser.toolbar.bottom.BottomToolbarConfiguration;

/**
Expand All @@ -20,8 +19,6 @@ public class BraveLauncherActivity extends Activity {
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);

SharedPreferencesManager.getInstance().disableKeyCheckerForTesting();

BottomToolbarConfiguration.isBottomToolbarEnabled();
BraveHelper.DisableFREDRP();
}
Expand Down
Loading

0 comments on commit 0f7207b

Please sign in to comment.