Rename 'incognito' to 'private' when rebasing chromium strings #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petemill
added a commit
to brave/brave-core
that referenced
this pull request
Oct 29, 2018
This is the auto-generated output as a result from brave/brave-browser#1890 Any desired changes to this output will have to result in a change to the re-basing script, and a re-generation of these files. Re-land #683 Fix brave/brave-browser#738
18 tasks
bbondy
approved these changes
Nov 8, 2018
|
uplifted since it's only used for strings, and strings update will be applied. |
bbondy
pushed a commit
to brave/brave-core
that referenced
this pull request
Nov 15, 2018
This is the auto-generated output as a result from brave/brave-browser#1890 Any desired changes to this output will have to result in a change to the re-basing script, and a re-generation of these files. Re-land #683 Fix brave/brave-browser#738
bbondy
pushed a commit
to brave/brave-core
that referenced
this pull request
Nov 15, 2018
This is the auto-generated output as a result from brave/brave-browser#1890 Any desired changes to this output will have to result in a change to the re-basing script, and a re-generation of these files. Re-land #683 Fix brave/brave-browser#738
bbondy
pushed a commit
to brave/brave-core
that referenced
this pull request
Nov 15, 2018
This is the auto-generated output as a result from brave/brave-browser#1890 Any desired changes to this output will have to result in a change to the re-basing script, and a re-generation of these files. Re-land #683 Fix brave/brave-browser#738
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #738.
Should probably not be merged until brave-core counterpart is approved, since any changes desired from that output would warrant changes in this script.
Also makes the IO async - apologies if that's annoying.