-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chromium strings to change 'incognito' to 'private' #761
Conversation
This is the auto-generated output as a result from brave/brave-browser#1890 Any desired changes to this output will have to result in a change to the re-basing script, and a re-generation of these files. Re-land #683 Fix brave/brave-browser#738
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't change generated grd and grdp files directly.
@bbondy this is just the generated output from brave/brave-browser#1890 which is still awaiting review |
Gotcha, why not the same PR? |
@bbondy different repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but pls regenerate the files again.
Clearing the Could we get this merged into |
This is the auto-generated output as a result from brave/brave-browser#1890
Any desired changes to this output will have to result in a change to the re-basing script, and a re-generation of these files.
Re-land #683
Fix brave/brave-browser#738
Note that this should probably only land on a release branch where the updated strings will be sent for translation updates. This is because language translations are hashed against the source English string, and therefore will be invalidated by these updates.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: