Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm audit vulnerabilities for 1.7.x #8940

Closed
wants to merge 1 commit into from
Closed

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Mar 31, 2020

Uplift of #8788
Fixes #8722
Related brave/brave-core#5115

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

Fixes #8722 for 1.7 (`brave-browser`)
@bsclifton bsclifton added this to the 1.7.x - Beta milestone Mar 31, 2020
@bsclifton bsclifton requested a review from a team March 31, 2020 16:54
@bsclifton bsclifton self-assigned this Mar 31, 2020
@bsclifton bsclifton changed the base branch from master to 1.7.x March 31, 2020 16:55
@kjozwiak
Copy link
Member

@bsclifton
Copy link
Member Author

Looks like this failed across the board; during build webpack error happens.

11:11:51  ERROR in /Users/jenkins/jenkins/workspace/brave-browser-build-pr_PR-8940/src/brave/components/brave_extension/extension/brave_extension/background.ts
11:11:51  ./components/brave_extension/extension/brave_extension/background.ts
11:11:51  [tsl] ERROR in /Users/jenkins/jenkins/workspace/brave-browser-build-pr_PR-8940/src/brave/components/brave_extension/extension/brave_extension/background.ts(6,1)
11:11:51        TS2741: Property '[Symbol.species]' is missing in type 'typeof Bluebird' but required in type 'PromiseConstructor'.
11:11:51  
11:11:51  ERROR in /Users/jenkins/jenkins/workspace/brave-browser-build-pr_PR-8940/src/brave/node_modules/brave-ui/src/components/buttonsIndicators/button/index.tsx
11:11:51  [tsl] ERROR in /Users/jenkins/jenkins/workspace/brave-browser-build-pr_PR-8940/src/brave/node_modules/brave-ui/src/components/buttonsIndicators/button/index.tsx(65,8)
11:11:51        TS2322: Type '{ children: (Element | null)[]; text: string; size?: "small" | "medium" | "call-to-action" | "large" | undefined; type?: "default" | "accent" | "warn" | "subtle" | undefined; brand?: "brave" | "rewards" | undefined; ... 6 more ...; disabled: boolean | undefined; }' is not assignable to type 'Readonly<ThemedOuterStyledProps<Props & ClassAttributes<HTMLButtonElement> & ButtonHTMLAttributes<HTMLButtonElement>, any>>'.
11:11:51    Types of property 'type' are incompatible.
11:11:51      Type '"default" | "accent" | "warn" | "subtle" | undefined' is not assignable to type 'undefined'.
11:11:51        Type '"default"' is not assignable to type 'undefined'.
11:11:51  npm ERR! code ELIFECYCLE
11:11:51  npm ERR! errno 2

Was worth trying a quick fix- this would need a more involved solution unfortunately

@bsclifton bsclifton closed this Mar 31, 2020
@bsclifton bsclifton deleted the bsc-fix-npm-1.7 branch March 31, 2020 22:32
@bsclifton bsclifton removed this from the 1.7.x - Beta milestone Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm vulnerability: minimist
2 participants